Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SaveWindowPosition as it is broken #196

Closed
batzen opened this issue Nov 10, 2015 · 2 comments
Closed

Remove SaveWindowPosition as it is broken #196

batzen opened this issue Nov 10, 2015 · 2 comments
Assignees
Labels
Milestone

Comments

@batzen
Copy link
Member

batzen commented Nov 10, 2015

SaveWindowPosition is broken for a long time now and no one seems to be using it.
The functionality of saving/restoring window positions should not be part of this library as I want to focus on the ribbon.

@batzen batzen self-assigned this Nov 10, 2015
@batzen batzen added this to the 4.0.0 milestone Nov 10, 2015
@chrfin
Copy link
Contributor

chrfin commented Nov 12, 2015

I did not know this was even part of this library, but I am using such a functionality implemented in my own window inheriting RibbonWindow, which works fine (including when detaching monitors, as it is based on the native function SetWindowPlacement of Windows).
If you are interested I could add it to this library, but I will not if you do not want such functionality anyhow?

@batzen
Copy link
Member Author

batzen commented Nov 16, 2015

I was thinking about a new OSS project which could provide extended features independent from the ribbon.
Adding such a feature, or in this case keeping it here, feels kind of wrong because this library should focus on the ribbon itself.
As i am currently trying to share the WindowChrome code with the MahApps team I think it would be a good idea to share that feature with them too.
If I remember correctly the initial code for that feature was taken from there.
The library which will be used to shared code/features between the two projects will be https://github.com/punker76/Controlz
So maybe you could ask @punker76 if he'd like to see it being implemented there.

batzen added a commit that referenced this issue Dec 13, 2015
- Changing usage of WindowChromeBehavior to code behind instead of style
@batzen batzen closed this as completed Dec 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants