Add functionality to exclude tags from extraction and normalize space #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 tasks
dobbersc
requested changes
Feb 29, 2024
| text = element.text or "" if not isinstance(element, lxml.html.HtmlComment) else "" | ||
| children = "".join([_text_content(child) for child in element.iterchildren()]) or "" | ||
| tail = element.tail or "" | ||
| return text + children + tail |
There was a problem hiding this comment.
Suggested change
| return text + children + tail | |
| return f"{text}{children}{tail}" |
There was a problem hiding this comment.
I would prefer the plus concatenation over f-strings, it's just personal preference here.
There was a problem hiding this comment.
Ok, it's just to avoid the creation of an immediate string text + children with the f-string.
Co-authored-by: Conrad Dobberstein <29147025+dobbersc@users.noreply.github.com>
Co-authored-by: Conrad Dobberstein <29147025+dobbersc@users.noreply.github.com>
dobbersc
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As #338 showed (see Focus/Nation) sometimes JS is extracted as text into the article. This is due to Fundus using a broad XPath expression
string()to extract text from nodes. While this makes it fast and easy to extract text from subsequent nodes, it does not allow Fundus to skip tag types (like<script>) during text extraction.To address this issue this PR implements:
text_content(excluded_tags: List[str])defined onNodeto extract text only from non-excluded nodes down the pathnormalize-spaceto normalize spacing within all extracted text. Previously, extracted text was in a weird state betweenrawandnormalized. The normalization is done with' '.join(.split())