Update Bild Sources, Update SZ Parser #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxDall
requested changes
Feb 6, 2024
src/fundus/publishers/de/sz.py
Outdated
Comment on lines
22
to
25
| _subheadline_selector = XPath( | ||
| "//div[@itemprop='articleBody']//h3[@data-manual='subheadline']|" | ||
| "//div[@itemprop='articleBody']//h2[@data-manual='subheadline']" | ||
| ) |
There was a problem hiding this comment.
Normally h2 is reserved for titles so that seems a bit odd to me. Could you explain the reasoning why using both?
There was a problem hiding this comment.
I added it for backwards compatibility. But that was based on the thought that older articles might also be parsed by accessing the url. When I looked though older articles I found at least a case or two where the subheadings used h2 and I thought it couldn't hurt to add that to the selectors as well
MaxDall
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a SiteMap and NewsMap for Bild, so I decided to add that.
I have also fixed the paragraph and subheadline selectors for SZ. I have not created a new parser class for this, since SZ has seemed to have updated their UI entirely and the selectors work (at least as well as the old ones) on all available articles (e.g. https://www.sueddeutsche.de/politik/bundesrat-union-sperrt-sich-gegen-neue-handwerksordnung-1.309844 from 2003)