Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo in DIRKIMEXMethod #121

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed typo in DIRKIMEXMethod #121

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40f0e9d
Fixed typo
jmbigman Feb 25, 2025
d993b08
Added missing lines to IMEX from DIRK to fix bc issue
jmbigman Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion irksome/imex.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ def getFormsDIRKIMEX(F, Fexp, ks, khats, butch, t, dt, u0, bcs=None):
k_bits = np.array(split(k), dtype=object)
u0bits = split(u0)
gbits = split(g)
ghat_bits = split(g)
ghat_bits = split(ghat)

# Note: the Constant c is used for substitution in both the
# implicit variational form and BC's, and we update it for each stage in
Expand Down Expand Up @@ -374,6 +374,10 @@ def getFormsDIRKIMEX(F, Fexp, ks, khats, butch, t, dt, u0, bcs=None):
for bc in bcs:
bcarg = as_ufl(bc._original_arg)
bcarg_stage = replace(bcarg, {t: t+c*dt})
if bcarg_stage == 0:
# Homogeneous BC, just zero out stage dofs
bcnew.append(bc.reconstruct(g=0))
continue

gdat = bcarg_stage - bc2space(bc, u0)
for i in range(num_stages):
Expand Down