Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fs-bq-schema-views - breaking changes in v0.4.9 #2248

Open
madmacc opened this issue Jan 6, 2025 · 5 comments · May be fixed by #2316
Open

🐛 fs-bq-schema-views - breaking changes in v0.4.9 #2248

madmacc opened this issue Jan 6, 2025 · 5 comments · May be fixed by #2316
Assignees
Labels
type: bug Something isn't working

Comments

@madmacc
Copy link

madmacc commented Jan 6, 2025

[REQUIRED] Step 3: Describe the problem

My old scripts that worked for version v0.4.7 no longer work with v0.4.9 which was released last month.
As far as I can tell the parameter names are the same.

Steps to reproduce:

Run:
npx @firebaseextensions/fs-bq-schema-views --non-interactive --project="projectname" --dataset="datasetname" --table-name-prefix="tags" --schema-files="./Schemas/tags.json"

This causing the help information to be displayed:
Usage: gen-schema-views [options]

Generate strongly-typed BigQuery Views based on raw JSON

Options:
-V, --version output the version number
--non-interactive Parse all input from command line flags instead of prompting the caller. (default: false)
-P, --project Firebase Project ID for project containing Cloud Firestore database.
-B, --big-query-project Google Cloud Project ID for BigQuery (can be the same as the Firebase project ID).
-d, --dataset The ID of the BigQuery dataset containing a raw Cloud Firestore document changelog.
-t, --table-name-prefix A common prefix for the names of all views generated by this script.
-f, --schema-files A collection of files from which to read schemas. (default: [])
-h, --help display help for command

Expected result

View is created.

Actual result

Help info displayed as above.

Fix:
Run:
npm install @firebaseextensions/fs-bq-schema-views@0.4.7
Run the command above again and it works.

@madmacc madmacc added the type: bug Something isn't working label Jan 6, 2025
@abarone-btf
Copy link

Same, is this a normal behavior? 🤔 , what is wrong?

@cabljac
Copy link
Contributor

cabljac commented Jan 31, 2025

Image

I think I can see the issue, it was introduced with a fix for reading multiple schema files.

@madmacc
Copy link
Author

madmacc commented Feb 1, 2025

@cabljac I am using the --project parameter in my example above. Do you mean it needs the bigQueryProject specified?

@cabljac
Copy link
Contributor

cabljac commented Feb 11, 2025

@madmacc I'll hopefully have resource to work on a fix for this soon, I think in the meantime my best advice is to use the version of the script which works for you. Apologies for the breaking change that went through!

@madmacc
Copy link
Author

madmacc commented Feb 11, 2025

@cabljac Thanks for looking into this. No rush on my part as you suggested I'm just using the previous version with no issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants