Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated links in Task 1 and Task 3 #48

Open
KulaginVladimir opened this issue Mar 22, 2024 · 1 comment
Open

Outdated links in Task 1 and Task 3 #48

KulaginVladimir opened this issue Mar 22, 2024 · 1 comment
Labels
good first issue Good for newcomers

Comments

@KulaginVladimir
Copy link
Contributor

Some links in Task 1 are outdated:

"> All units in FESTIM as SI (apart for activation energies that are in eV)\n",
"> To check what unit is expected by FESTIM, check the documentation. [Here](https://festim.readthedocs.io/en/latest/api/festim.materials.html#festim.materials.material.Material) is the reference for the `Material` class"

"FESTIM provides plenty of boundary conditions (see [Dirichlet BCs](https://festim.readthedocs.io/en/latest/api/festim.boundary_conditions.dirichlets.html#festim-boundary-conditions-dirichlets-package) and [Fluxes](https://festim.readthedocs.io/en/latest/api/festim.boundary_conditions.fluxes.html)).\n",

I also missed this one in #46. Sorry about that.

">For heat transfer simulations, the `HeatTransferProblem` can be used instead. See [Heat transfer simulation](https://github.com/festim-dev/FESTIM-workshop/blob/main/tasks/task6.ipynb)"

and in Task 3:

" ![image](https://github.com/RemDelaporteMathurin/FESTIM-workshop/assets/40028739/74b7f8aa-67f6-4a70-b712-fc994b272622)\n",

@RemDelaporteMathurin
Copy link
Collaborator

The links to the docs should be easy to fix.
To fix the link to the image in Task 3 one would need to rerun the notebook to obtain it 😄

@RemDelaporteMathurin RemDelaporteMathurin added the good first issue Good for newcomers label Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants