to_base: Error output mismatch between Velox and Presto

[peterenescu]

Description

to_base produces mismatched error outputs between Presto and Velox queries. Error is minor, just a output difference, but causing fuzzer failures likely to different parsed output.

Reproduction

Velox

presto:di> select to_base(c0, c1) from (values (5456023125742555402, 1389805446764088687)) t(c0, c1);

Query 20250304_222614_00052_rd7dj failed: radix <= kMaxRadix (1389805446764088687 vs. 36) Radix must be between 2 and 36. Top-level Expression: presto.default.to_base(field, field_0)

Presto

presto:tpch> select to_base(c0, c1) as p0, row_number as p1 FROM (t_values);

Query 20250304_222422_07556_hjmrr failed: Radix must be between 2 and 36

[kagamiori]

Hi @peterenescu, it's OK for Presto and Velox to have different error messages, as long as they both throw or both not throw on the same input. We don't require the error messages to be the same.

[peterenescu]

(Followed up with Wei above) Fuzzer shouldn't throw for different error outputs, but in the actual runs from where I generated the output for this issue, it looks like Velox doesn't throw because of its default null behavior (but still may and we shouldn't error for it). Created issue for actual issue caused by fuzzer default null handling: #12548