Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix compilation failure in VectorMakerTest #12495

Closed
wants to merge 1 commit into from
Closed

fix: Fix compilation failure in VectorMakerTest #12495

wants to merge 1 commit into from

Conversation

rui-mo
Copy link
Collaborator

@rui-mo rui-mo commented Feb 28, 2025

Fixes #12494.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 28, 2025
@netlify Netlify
Copy link

netlify bot commented Feb 28, 2025 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit c4ec7f0
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/67c1e3a31e2774000824f2fe

pedroerp
pedroerp approved these changes Feb 28, 2025
View reviewed changes
Copy link
Contributor

@pedroerp pedroerp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a compiler-specific issue? This seems to compile fine in our internal Clang-based platform.

@rui-mo
Copy link
Collaborator Author

rui-mo commented Feb 28, 2025

-- The C compiler identification is GNU 13.3.0
-- The CXX compiler identification is GNU 13.3.0

@pedroerp The compilation issue only occurs when recompiling the experimental fuzzer test (similar as #12342). Likely due to the gcc 13 version used in this job.

@rui-mo
Copy link
Collaborator Author

rui-mo commented Mar 10, 2025

This change is covered by #12517. Closing as duplicate.

@rui-mo rui-mo closed this Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedroerp pedroerp pedroerp approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Converting from initializer list would use explicit constructor
3 participants
@rui-mo @pedroerp @facebook-github-bot