Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converting from initializer list would use explicit constructor #12494

Open
rui-mo opened this issue Feb 28, 2025 · 0 comments
Open

Converting from initializer list would use explicit constructor #12494

rui-mo opened this issue Feb 28, 2025 · 0 comments
Labels
build triage Newly created issue that needs attention.

Comments

@rui-mo
Copy link
Collaborator

rui-mo commented Feb 28, 2025

Problem description

/home/runner/work/velox/velox/velox/velox/vector/tests/VectorMakerTest.cpp:477:65: error: converting to ‘std::optional<std::vector<std::optional<int>, std::allocator<std::optional<int> > > >’ from initializer list would use explicit constructor ‘constexpr std::optional<_Tp>::optional(std::in_place_t, _Args&& ...) [with _Args = {}; typename std::enable_if<__and_v<std::is_constructible<_Tp, _Args ...> >, bool>::type <anonymous> = false; _Tp = std::vector<std::optional<int>, std::allocator<std::optional<int> > >]’
/home/runner/work/velox/velox/velox/velox/vector/tests/VectorMakerTest.cpp:477:65: error: converting to ‘std::in_place_t’ from initializer list would use explicit constructor ‘constexpr std::in_place_t::in_place_t()’
/home/runner/work/velox/velox/velox/velox/vector/tests/VectorMakerTest.cpp:477:65: error: converting to ‘std::optional<std::vector<std::optional<int>, std::allocator<std::optional<int> > > >’ from initializer list would use explicit constructor ‘constexpr std::optional<_Tp>::optional(std::in_place_t, _Args&& ...) [with _Args = {}; typename std::enable_if<__and_v<std::is_constructible<_Tp, _Args ...> >, bool>::type <anonymous> = false; _Tp = std::vector<std::optional<int>, std::allocator<std::optional<int> > >]’

System information

Velox System Info v0.0.2
Commit: 1499c95
CMake Version: 3.31.5
System: Darwin-23.6.0
Arch: arm64
C++ Compiler: /Library/Developer/CommandLineTools/usr/bin/c++
C++ Compiler Version: 16.0.0.16000026
C Compiler: /Library/Developer/CommandLineTools/usr/bin/cc
C Compiler Version: 16.0.0.16000026
CMake Prefix Path: /Library/Developer/CommandLineTools/SDKs/MacOSX15.2.sdk/usr;/opt/homebrew;/usr/local;/usr;/;/opt/homebrew;/usr/local;/usr/X11R6;/usr/pkg;/opt;/sw;/opt/local

CMake log

https://github.com/facebookincubator/velox/actions/runs/13585069008/job/37978164870?pr=9559
@rui-mo rui-mo added build triage Newly created issue that needs attention. labels Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build triage Newly created issue that needs attention.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant