From 21c95bb9c9523afbaef8308741d529d6e6b15a65 Mon Sep 17 00:00:00 2001 From: Jagdish Prajapati Date: Fri, 10 Jan 2025 01:30:19 +0530 Subject: [PATCH 01/13] updating tests for Reverse-String exercise --- .../practice/reverse-string/.meta/config.json | 3 +++ .../practice/reverse-string/.meta/tests.toml | 22 ++++++++++++++++--- .../reverse-string/test_reverse_string.c | 15 +++++++++++++ 3 files changed, 37 insertions(+), 3 deletions(-) diff --git a/exercises/practice/reverse-string/.meta/config.json b/exercises/practice/reverse-string/.meta/config.json index e55cd44fc..0d0fb4171 100644 --- a/exercises/practice/reverse-string/.meta/config.json +++ b/exercises/practice/reverse-string/.meta/config.json @@ -2,6 +2,9 @@ "authors": [ "keiravillekode" ], + "contributors": [ + "jagdish-15" + ], "files": { "solution": [ "reverse_string.c", diff --git a/exercises/practice/reverse-string/.meta/tests.toml b/exercises/practice/reverse-string/.meta/tests.toml index 2113a5336..0c313cc53 100644 --- a/exercises/practice/reverse-string/.meta/tests.toml +++ b/exercises/practice/reverse-string/.meta/tests.toml @@ -1,6 +1,13 @@ -# This is an auto-generated file. Regular comments will be removed when this -# file is regenerated. Regenerating will not touch any manually added keys, -# so comments can be added in a "comment" key. +# This is an auto-generated file. +# +# Regenerating this file via `configlet sync` will: +# - Recreate every `description` key/value pair +# - Recreate every `reimplements` key/value pair, where they exist in problem-specifications +# - Remove any `include = true` key/value pair (an omitted `include` key implies inclusion) +# - Preserve any other key/value pair +# +# As user-added comments (using the # character) will be removed when this file +# is regenerated, comments can be added via a `comment` key. [c3b7d806-dced-49ee-8543-933fd1719b1c] description = "an empty string" @@ -19,3 +26,12 @@ description = "a palindrome" [b9e7dec1-c6df-40bd-9fa3-cd7ded010c4c] description = "an even-sized word" + +[1bed0f8a-13b0-4bd3-9d59-3d0593326fa2] +description = "wide characters" + +[93d7e1b8-f60f-4f3c-9559-4056e10d2ead] +description = "grapheme cluster with pre-combined form" + +[1028b2c1-6763-4459-8540-2da47ca512d9] +description = "grapheme clusters" diff --git a/exercises/practice/reverse-string/test_reverse_string.c b/exercises/practice/reverse-string/test_reverse_string.c index 5cd318b22..465fb95e6 100644 --- a/exercises/practice/reverse-string/test_reverse_string.c +++ b/exercises/practice/reverse-string/test_reverse_string.c @@ -50,6 +50,21 @@ static void test_an_even_sized_word(void) test_reverse("drawer", "reward"); } +static void test_wide_characters(void) +{ + test_reverse("子猫", "猫子"); +} + +static void test_grapheme_cluster_with_pre_combined_form(void) +{ + test_reverse("Würstchenstand", "dnatsnehctsrüW"); +} + +static void test_grapheme_clusters(void) +{ + test_reverse("ผู้เขียนโปรแกรม", "มรกแรปโนยขีเผู้"); +} + int main(void) { UNITY_BEGIN(); From c93a8f64d50c05c7ee8cc3285380cf86e4857376 Mon Sep 17 00:00:00 2001 From: Jagdish Prajapati Date: Fri, 10 Jan 2025 01:43:12 +0530 Subject: [PATCH 02/13] Adding new tests to main function --- exercises/practice/reverse-string/test_reverse_string.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/exercises/practice/reverse-string/test_reverse_string.c b/exercises/practice/reverse-string/test_reverse_string.c index 465fb95e6..50dc3e7a6 100644 --- a/exercises/practice/reverse-string/test_reverse_string.c +++ b/exercises/practice/reverse-string/test_reverse_string.c @@ -75,6 +75,9 @@ int main(void) RUN_TEST(test_a_sentence_with_punctuation); RUN_TEST(test_a_palindrome); RUN_TEST(test_an_even_sized_word); + RUN_TEST(test_wide_characters); + RUN_TEST(test_grapheme_cluster_with_pre_combined_form); + RUN_TEST(test_grapheme_clusters); return UNITY_END(); } From 7f577ec6396f31f731ed1f2320c613a20b6c23bc Mon Sep 17 00:00:00 2001 From: Jagdish Prajapati Date: Fri, 17 Jan 2025 12:50:05 +0530 Subject: [PATCH 03/13] Commenting out failing tests --- .../practice/reverse-string/test_reverse_string.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/exercises/practice/reverse-string/test_reverse_string.c b/exercises/practice/reverse-string/test_reverse_string.c index 50dc3e7a6..82be9c478 100644 --- a/exercises/practice/reverse-string/test_reverse_string.c +++ b/exercises/practice/reverse-string/test_reverse_string.c @@ -75,9 +75,18 @@ int main(void) RUN_TEST(test_a_sentence_with_punctuation); RUN_TEST(test_a_palindrome); RUN_TEST(test_an_even_sized_word); - RUN_TEST(test_wide_characters); - RUN_TEST(test_grapheme_cluster_with_pre_combined_form); - RUN_TEST(test_grapheme_clusters); + + /* + Commenting out the following tests for now because the current implementation + does not support handling wide characters, grapheme clusters, or UTF characters. + The implementation currently only handles 8-bit ASCII characters, so these tests + will cause failures when executed. Once support for wider character sets is added, + these tests can be re-enabled for proper validation. + */ + + // RUN_TEST(test_wide_characters); + // RUN_TEST(test_grapheme_cluster_with_pre_combined_form); + // RUN_TEST(test_grapheme_clusters); return UNITY_END(); } From 88b412b593e85872022d4a4d33f8fc36dc84f379 Mon Sep 17 00:00:00 2001 From: Jagdish Prajapati Date: Fri, 17 Jan 2025 12:51:54 +0530 Subject: [PATCH 04/13] Fixing formatting issues --- .../practice/reverse-string/test_reverse_string.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/exercises/practice/reverse-string/test_reverse_string.c b/exercises/practice/reverse-string/test_reverse_string.c index 82be9c478..fb64af2a5 100644 --- a/exercises/practice/reverse-string/test_reverse_string.c +++ b/exercises/practice/reverse-string/test_reverse_string.c @@ -77,11 +77,11 @@ int main(void) RUN_TEST(test_an_even_sized_word); /* - Commenting out the following tests for now because the current implementation - does not support handling wide characters, grapheme clusters, or UTF characters. - The implementation currently only handles 8-bit ASCII characters, so these tests - will cause failures when executed. Once support for wider character sets is added, - these tests can be re-enabled for proper validation. + Commenting out the following tests for now because the current implementation + does not support handling wide characters, grapheme clusters, or UTF characters. + The implementation currently only handles 8-bit ASCII characters, so these tests + will cause failures when executed. Once support for wider character sets is added, + these tests can be re-enabled for proper validation. */ // RUN_TEST(test_wide_characters); From f70b6b96189d6a37ad5a6fa195fd265e0a0af59f Mon Sep 17 00:00:00 2001 From: Jagdish Prajapati Date: Fri, 17 Jan 2025 12:54:16 +0530 Subject: [PATCH 05/13] Fixing formatting issues, hopefully --- exercises/practice/reverse-string/test_reverse_string.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exercises/practice/reverse-string/test_reverse_string.c b/exercises/practice/reverse-string/test_reverse_string.c index fb64af2a5..2d5e34edb 100644 --- a/exercises/practice/reverse-string/test_reverse_string.c +++ b/exercises/practice/reverse-string/test_reverse_string.c @@ -80,7 +80,7 @@ int main(void) Commenting out the following tests for now because the current implementation does not support handling wide characters, grapheme clusters, or UTF characters. The implementation currently only handles 8-bit ASCII characters, so these tests - will cause failures when executed. Once support for wider character sets is added, + will cause failures when executed. Once support for wider character sets is added, these tests can be re-enabled for proper validation. */ From 6b517e25e79f52635b10111b58b4d73a2051eea8 Mon Sep 17 00:00:00 2001 From: Jagdish Prajapati Date: Fri, 17 Jan 2025 13:01:21 +0530 Subject: [PATCH 06/13] Fixing formatting issues --- .../practice/reverse-string/test_reverse_string.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/exercises/practice/reverse-string/test_reverse_string.c b/exercises/practice/reverse-string/test_reverse_string.c index 2d5e34edb..a2fa829bf 100644 --- a/exercises/practice/reverse-string/test_reverse_string.c +++ b/exercises/practice/reverse-string/test_reverse_string.c @@ -77,11 +77,11 @@ int main(void) RUN_TEST(test_an_even_sized_word); /* - Commenting out the following tests for now because the current implementation - does not support handling wide characters, grapheme clusters, or UTF characters. - The implementation currently only handles 8-bit ASCII characters, so these tests - will cause failures when executed. Once support for wider character sets is added, - these tests can be re-enabled for proper validation. + * Commenting out the following tests for now because the current implementation + * does not support handling wide characters, grapheme clusters, or UTF characters. + * The implementation currently only handles 8-bit ASCII characters, so these tests + * will cause failures when executed. Once support for wider character sets is added, + * these tests can be re-enabled for proper validation. */ // RUN_TEST(test_wide_characters); From 1683a6200798a010e76a70b04b6b3b82ad88d87c Mon Sep 17 00:00:00 2001 From: Jagdish Prajapati Date: Fri, 17 Jan 2025 13:04:17 +0530 Subject: [PATCH 07/13] Fixing formatting issues with clang-format --- .../practice/reverse-string/test_reverse_string.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/exercises/practice/reverse-string/test_reverse_string.c b/exercises/practice/reverse-string/test_reverse_string.c index a2fa829bf..27e69713f 100644 --- a/exercises/practice/reverse-string/test_reverse_string.c +++ b/exercises/practice/reverse-string/test_reverse_string.c @@ -77,12 +77,13 @@ int main(void) RUN_TEST(test_an_even_sized_word); /* - * Commenting out the following tests for now because the current implementation - * does not support handling wide characters, grapheme clusters, or UTF characters. - * The implementation currently only handles 8-bit ASCII characters, so these tests - * will cause failures when executed. Once support for wider character sets is added, - * these tests can be re-enabled for proper validation. - */ + * Commenting out the following tests for now because the current + * implementation does not support handling wide characters, grapheme + * clusters, or UTF characters. The implementation currently only handles + * 8-bit ASCII characters, so these tests will cause failures when executed. + * Once support for wider character sets is added, these tests can be + * re-enabled for proper validation. + */ // RUN_TEST(test_wide_characters); // RUN_TEST(test_grapheme_cluster_with_pre_combined_form); From a733e7a977ce3ef60a66640148984cfd54f06c83 Mon Sep 17 00:00:00 2001 From: Jagdish Prajapati Date: Fri, 17 Jan 2025 13:07:19 +0530 Subject: [PATCH 08/13] Disebling test functions --- exercises/practice/reverse-string/test_reverse_string.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/exercises/practice/reverse-string/test_reverse_string.c b/exercises/practice/reverse-string/test_reverse_string.c index 27e69713f..1c02d1785 100644 --- a/exercises/practice/reverse-string/test_reverse_string.c +++ b/exercises/practice/reverse-string/test_reverse_string.c @@ -50,6 +50,7 @@ static void test_an_even_sized_word(void) test_reverse("drawer", "reward"); } +#if 0 static void test_wide_characters(void) { test_reverse("子猫", "猫子"); @@ -64,6 +65,7 @@ static void test_grapheme_clusters(void) { test_reverse("ผู้เขียนโปรแกรม", "มรกแรปโนยขีเผู้"); } +#endif int main(void) { From e200d22031fb5422b3365863fed541fa4c403ac9 Mon Sep 17 00:00:00 2001 From: jagdish-15 Date: Sun, 26 Jan 2025 15:04:42 +0530 Subject: [PATCH 09/13] Update exercises/practice/reverse-string/.meta/tests.toml Co-authored-by: wolf99 <281700+wolf99@users.noreply.github.com> --- exercises/practice/reverse-string/.meta/tests.toml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/exercises/practice/reverse-string/.meta/tests.toml b/exercises/practice/reverse-string/.meta/tests.toml index 0c313cc53..bc4937981 100644 --- a/exercises/practice/reverse-string/.meta/tests.toml +++ b/exercises/practice/reverse-string/.meta/tests.toml @@ -29,6 +29,8 @@ description = "an even-sized word" [1bed0f8a-13b0-4bd3-9d59-3d0593326fa2] description = "wide characters" +include = false +comment = "track decision to only handle ASCII strings for this exercise" [93d7e1b8-f60f-4f3c-9559-4056e10d2ead] description = "grapheme cluster with pre-combined form" From 792d93e416289f0b67cc3c7b9fdc970aae798118 Mon Sep 17 00:00:00 2001 From: jagdish-15 Date: Sun, 26 Jan 2025 15:04:50 +0530 Subject: [PATCH 10/13] Update exercises/practice/reverse-string/.meta/tests.toml Co-authored-by: wolf99 <281700+wolf99@users.noreply.github.com> --- exercises/practice/reverse-string/.meta/tests.toml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/exercises/practice/reverse-string/.meta/tests.toml b/exercises/practice/reverse-string/.meta/tests.toml index bc4937981..2e121eed0 100644 --- a/exercises/practice/reverse-string/.meta/tests.toml +++ b/exercises/practice/reverse-string/.meta/tests.toml @@ -34,6 +34,8 @@ comment = "track decision to only handle ASCII strings for this exercise" [93d7e1b8-f60f-4f3c-9559-4056e10d2ead] description = "grapheme cluster with pre-combined form" +include = false +comment = "track decision to only handle ASCII strings for this exercise" [1028b2c1-6763-4459-8540-2da47ca512d9] description = "grapheme clusters" From 9aa278d92be187448b225eddd436b16c70553592 Mon Sep 17 00:00:00 2001 From: jagdish-15 Date: Sun, 26 Jan 2025 15:04:58 +0530 Subject: [PATCH 11/13] Update exercises/practice/reverse-string/.meta/tests.toml Co-authored-by: wolf99 <281700+wolf99@users.noreply.github.com> --- exercises/practice/reverse-string/.meta/tests.toml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/exercises/practice/reverse-string/.meta/tests.toml b/exercises/practice/reverse-string/.meta/tests.toml index 2e121eed0..4994dc04e 100644 --- a/exercises/practice/reverse-string/.meta/tests.toml +++ b/exercises/practice/reverse-string/.meta/tests.toml @@ -39,3 +39,5 @@ comment = "track decision to only handle ASCII strings for this exercise" [1028b2c1-6763-4459-8540-2da47ca512d9] description = "grapheme clusters" +include = false +comment = "track decision to only handle ASCII strings for this exercise" From 17ab1ea18c63969f2643218cdf47ae643a08a325 Mon Sep 17 00:00:00 2001 From: jagdish-15 Date: Sun, 26 Jan 2025 15:05:12 +0530 Subject: [PATCH 12/13] Update exercises/practice/reverse-string/test_reverse_string.c Co-authored-by: wolf99 <281700+wolf99@users.noreply.github.com> --- .../reverse-string/test_reverse_string.c | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/exercises/practice/reverse-string/test_reverse_string.c b/exercises/practice/reverse-string/test_reverse_string.c index 1c02d1785..777143eb5 100644 --- a/exercises/practice/reverse-string/test_reverse_string.c +++ b/exercises/practice/reverse-string/test_reverse_string.c @@ -50,23 +50,6 @@ static void test_an_even_sized_word(void) test_reverse("drawer", "reward"); } -#if 0 -static void test_wide_characters(void) -{ - test_reverse("子猫", "猫子"); -} - -static void test_grapheme_cluster_with_pre_combined_form(void) -{ - test_reverse("Würstchenstand", "dnatsnehctsrüW"); -} - -static void test_grapheme_clusters(void) -{ - test_reverse("ผู้เขียนโปรแกรม", "มรกแรปโนยขีเผู้"); -} -#endif - int main(void) { UNITY_BEGIN(); From 72a7aa4b1d927723d6c51d04eeaa74f23a4fa416 Mon Sep 17 00:00:00 2001 From: Jagdish Prajapati Date: Sun, 26 Jan 2025 15:49:04 +0530 Subject: [PATCH 13/13] Going behind the commit causing check issue --- exercises/practice/reverse-string/.meta/config.json | 3 ++- .../practice/reverse-string/test_reverse_string.c | 13 ------------- 2 files changed, 2 insertions(+), 14 deletions(-) diff --git a/exercises/practice/reverse-string/.meta/config.json b/exercises/practice/reverse-string/.meta/config.json index 0d0fb4171..8a45e6ef1 100644 --- a/exercises/practice/reverse-string/.meta/config.json +++ b/exercises/practice/reverse-string/.meta/config.json @@ -3,7 +3,8 @@ "keiravillekode" ], "contributors": [ - "jagdish-15" + "jagdish-15", + "wolf99" ], "files": { "solution": [ diff --git a/exercises/practice/reverse-string/test_reverse_string.c b/exercises/practice/reverse-string/test_reverse_string.c index 777143eb5..5cd318b22 100644 --- a/exercises/practice/reverse-string/test_reverse_string.c +++ b/exercises/practice/reverse-string/test_reverse_string.c @@ -61,18 +61,5 @@ int main(void) RUN_TEST(test_a_palindrome); RUN_TEST(test_an_even_sized_word); - /* - * Commenting out the following tests for now because the current - * implementation does not support handling wide characters, grapheme - * clusters, or UTF characters. The implementation currently only handles - * 8-bit ASCII characters, so these tests will cause failures when executed. - * Once support for wider character sets is added, these tests can be - * re-enabled for proper validation. - */ - - // RUN_TEST(test_wide_characters); - // RUN_TEST(test_grapheme_cluster_with_pre_combined_form); - // RUN_TEST(test_grapheme_clusters); - return UNITY_END(); }