Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow 'all-day' text to be translatable and set the time format uses on the calendar axis #18

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Pebblo
Copy link
Member

@Pebblo Pebblo commented Sep 14, 2021

See: https://eventespresso.com/topic/calendar-time-column/?view=all#post-326944

The changes in this branch allow for the default 'all-day' text used by full calendar to be translated.

It also adds a 'axis time format' option to the calendar settings to allow users to change the format used there.
(the default value for that option/parameter it what fullCalendar already uses)

How has this been tested

Go to Event Espresso -> Calendar

In basic settings you should have a 'Axis Settings' option and the default value should be h(:mm)tt

Open up the calendar in a new tab and check the Week and day views, confirm they show times on the left using the format 6pm.

In the settings again, change the format, for example, remove the tt and save, then confirm that value saves when you save the config.

Back to the front end calendar again, hard refresh and confirm the week and day views show the correct format (in this example, no AM/PM)

For the all-day text, install Pig Latin, activate it and confirm that with that plugin active the calendar displays something like allay-ayday, if so that string is now translatable.

Checklist

@Pebblo Pebblo requested a review from tn3rb September 14, 2021 14:43
@Pebblo Pebblo changed the title Enh/localize axis Allow 'all-day' text to be translatable and set the time format uses on the calendar axis Sep 14, 2021
tn3rb
tn3rb previously requested changes Sep 14, 2021
Copy link
Member

@tn3rb tn3rb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, but it needs a couple minor tweaks

@Pebblo
Copy link
Member Author

Pebblo commented Sep 15, 2021

Thanks, Brent! Feeling a little rusty now as I should have picked up on those lol

Dismissed review as GitHub showed requested changes even though they were done.

@Pebblo Pebblo dismissed tn3rb’s stale review September 15, 2021 11:35

Changes applied, github shows 1 remaining

@sethshoultes
Copy link
Contributor

Testing Notes:

Additional Testing Notes:

  • on an existing install, the default value for "Axis Time Format" was missing
  • on a fresh install, the default value for "Axis Time Format" is present
  • (also, reproduced on calendar/master) I noticed that the "Custom" Time Format shows \c\u\s\t\o\m in the text field when selected and the settings are saved, no matter what is entered into the field: https://www.screencast.com/t/kTinyc73f

@sethshoultes
Copy link
Contributor

@Pebblo did you see my notes above?

@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status:stale label Apr 16, 2022
@tn3rb tn3rb force-pushed the ENH/localize-axis branch from 53d1d47 to 1727b64 Compare July 11, 2022 20:23
@ghost
Copy link

ghost commented Jul 13, 2022

Tested it and works as expected! 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants