-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow 'all-day' text to be translatable and set the time format uses on the calendar axis #18
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, but it needs a couple minor tweaks
Thanks, Brent! Feeling a little rusty now as I should have picked up on those lol Dismissed review as GitHub showed requested changes even though they were done. |
Changes applied, github shows 1 remaining
Testing Notes:
Additional Testing Notes:
|
@Pebblo did you see my notes above? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Use eeCal to pull the string that should be used to 'all-day' (shown on the same views as above);
Co-authored-by: Brent Christensen <brent@eventespresso.com>
Co-authored-by: Brent Christensen <brent@eventespresso.com>
Tested it and works as expected! 💯 |
See: https://eventespresso.com/topic/calendar-time-column/?view=all#post-326944
The changes in this branch allow for the default 'all-day' text used by full calendar to be translated.
It also adds a 'axis time format' option to the calendar settings to allow users to change the format used there.
(the default value for that option/parameter it what fullCalendar already uses)
How has this been tested
Go to Event Espresso -> Calendar
In basic settings you should have a 'Axis Settings' option and the default value should be
h(:mm)tt
Open up the calendar in a new tab and check the Week and day views, confirm they show times on the left using the format
6pm
.In the settings again, change the format, for example, remove the
tt
and save, then confirm that value saves when you save the config.Back to the front end calendar again, hard refresh and confirm the week and day views show the correct format (in this example, no AM/PM)
For the all-day text, install Pig Latin, activate it and confirm that with that plugin active the calendar displays something like
allay-ayday
, if so that string is now translatable.Checklist
esc_html__()
, see https://codex.wordpress.org/I18n_for_WordPress_Developers)