Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide the response body with unsucessful responses #2

Open
etcinit opened this issue Mar 22, 2016 · 2 comments
Open

Provide the response body with unsucessful responses #2

etcinit opened this issue Mar 22, 2016 · 2 comments

Comments

@etcinit
Copy link
Owner

etcinit commented Mar 22, 2016

This should help with debugging: etcinit/phabulous#27

@lyoung-uber
Copy link

Not sure this was a complete fix. For example when running:

client, err := gonduit.Dial("REDACTED", &core.ClientOptions{
  APIToken: "api-REDACTED",
})

Results in the error logged to console:

(*json.UnmarshalTypeError)(0xc8203d0210)(json: cannot unmarshal object into Go value of type []interface {})

This is because the response from phab is not an array:

{"result":{"authentication":["..."],"signatures":["..."],"input":["..."],"output":["..."]},"error_code":null,"error_info":null}

Let me know if you need more info to diagnose. I simply commented out the spew.Dump line as it still functions correctly.

@etcinit
Copy link
Owner Author

etcinit commented Jun 9, 2016

Yep, looking at the code it seems I accidentally left in the spew.Dump call, which I was probably using for debugging.

etcinit added a commit that referenced this issue Jul 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants