Skip to content

Commit 6dba536

Browse files
committed
minor improvements
1 parent a495cdf commit 6dba536

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

README.md

+1-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
11
[`changes-8e18c70.json`](changes-8e18c70.json) contains the last glibc derivations available in nixpkgs since rev `8e18c70`.
2-
(This file can be generated by `nix run`, which calls `get-revisions.rb`)
2+
(This file can be generated by `nix run`, which calls [`get-revisions.rb`](./get-revisions.rb))
33

44
Run [`./check-compatibilities.sh`](./check-compatibilities.sh) to check various combinations of NSS modules and client binaries with differing glibc derivations.
5-
6-

get-revisions.rb

+5-3
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ def find_versions(versions_to_find: 10, start_depth: 0, log: Log.new)
1717
versions_found = 0
1818

1919
while versions_found < versions_to_find
20-
hi, _ = find_next_drv(prev_change)
21-
change = find_drv_change(prev_change, hi)
20+
upper_bound = find_next_drv(prev_change)
21+
change = find_drv_change(prev_change, upper_bound)
2222
@log.add_change(change)
2323
if change.version != prev_change.version
2424
versions_found += 1
@@ -38,7 +38,7 @@ def find_next_drv(change)
3838
break if drv != change.drv
3939
step *= 2
4040
end
41-
[depth, drv, version]
41+
depth
4242
end
4343

4444
# binary search for next change within arg `change` and
@@ -130,7 +130,9 @@ def print_depth(base, extra)
130130
end
131131
end
132132

133+
puts
133134
puts "Press ENTER to cleanly exit this program"
135+
puts
134136
Thread.new do
135137
gets
136138
@abort = true

0 commit comments

Comments
 (0)