Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve input checking: prefer checkmate for custom checks #174

Merged
merged 9 commits into from
Jan 16, 2024

Conversation

jamesmbaazam
Copy link
Member

@jamesmbaazam jamesmbaazam commented Jan 16, 2024

This PR closes #147 and fixes #162. It implements a few changes to improve how input checking is done:

  • Removes custom checks check_offspring_valid() and check_ntrees_valid() in favour of checkmate functions.
  • Refactors check_generation_time_valid() and check_offspring_func() valid to use checkmate::assert_* instead of !checkmate::test_*.

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d499296) 99.11% compared to head (1eabf96) 99.10%.
Report is 2 commits behind head on main.

❗ Current head 1eabf96 differs from pull request most recent head 5bf2e13. Consider uploading reports for the commit 5bf2e13 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #174      +/-   ##
==========================================
- Coverage   99.11%   99.10%   -0.01%     
==========================================
  Files           8        8              
  Lines         562      556       -6     
==========================================
- Hits          557      551       -6     
  Misses          5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants