Improve input checking: prefer checkmate for custom checks #174
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #147 and fixes #162. It implements a few changes to improve how input checking is done:
check_offspring_valid()
andcheck_ntrees_valid()
in favour ofcheckmate
functions.check_generation_time_valid()
andcheck_offspring_func()
valid to usecheckmate::assert_*
instead of!checkmate::test_*
.