Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove defaults from class constructors and validators #172

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Conversation

jamesmbaazam
Copy link
Member

This PR closes #161 by removing the empty defaults that were passed to the constructor and validation functions of <epichains_tree> and <epichains_summary> objects.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d499296) 99.11% compared to head (de9301b) 99.11%.
Report is 2 commits behind head on main.

❗ Current head de9301b differs from pull request most recent head 6761962. Consider uploading reports for the commit 6761962 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #172   +/-   ##
=======================================
  Coverage   99.11%   99.11%           
=======================================
  Files           8        8           
  Lines         562      562           
=======================================
  Hits          557      557           
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jamesmbaazam jamesmbaazam changed the title Remove defaults from class contructors and validators Remove defaults from class conctructors and validators Jan 16, 2024
@jamesmbaazam jamesmbaazam changed the title Remove defaults from class conctructors and validators Remove defaults from class constructors and validators Jan 16, 2024
@jamesmbaazam jamesmbaazam merged commit 4dc5354 into main Jan 16, 2024
7 checks passed
@jamesmbaazam jamesmbaazam deleted the issue-161 branch January 16, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove default empty vectors in constructors
2 participants