! more substirng from substr, === form ==, cruft

Author: Spuds

themes/default/images/mobile.png

@@ -5,7 +5,7 @@
  *
  * @version 2.0 dev
  *
- * This bits acts as middle-man between the notify (above) and the ElkNotifications
+ * This bits acts as middle-man between Push and the ElkNotifications
  * providing the interface required by the latter.
  */
 
@@ -15,14 +15,14 @@
 		opt = (opt) ? opt : {};
 
 		const send = function(request) {
-			if (request.desktop_notifications.new_from_last > 0)
+			if (request.desktop_notifications && request.desktop_notifications.new_from_last > 0)
 			{
 				if (hasPermissions(request))
 				{
 					Push.create(request.desktop_notifications.title, {
 						body: request.desktop_notifications.message,
 						icon: opt.icon,
-						link: request.desktop_notifications.link, // Used by mobile devices
+						link: request.desktop_notifications.link,
 						onClick: function() {
 							window.focus();
 							this.close();

themes/default/scripts/desktop-notify.js

@@ -87,7 +87,7 @@ function calcCharLeft (init, event = {})
 		return;
 	}
 
-	init = typeof init !== 'undefined' ? init : false;
+	init = typeof init === 'undefined' ? false : init;
 
 	currentChars = currentSignature.replace(/\r/, '').length;
 
@@ -268,8 +268,8 @@ function changeSel (selected)
 		{
 			if (files[i].indexOf(cat.options[cat.selectedIndex].value) === 0)
 			{
-				let filename = files[i].substr(files[i].indexOf('/') + 1),
-					showFilename = filename.substr(0, filename.lastIndexOf('.'));
+				let filename = files[i].substring(files[i].indexOf('/') + 1),
+					showFilename = filename.substring(0, filename.lastIndexOf('.'));
 
 				showFilename = showFilename.replace(/[_]/g, ' ');
 

themes/default/scripts/profile.js

@@ -434,15 +434,14 @@ function submitonce (theform)
 function submitThisOnce (oControl, bReadOnly)
 {
 	// oControl might also be a form.
-	var oForm = 'form' in oControl ? oControl.form : oControl,
+	let oForm = 'form' in oControl ? oControl.form : oControl,
 		aTextareas = oForm.getElementsByTagName('textarea');
 
-	bReadOnly = typeof bReadOnly == 'undefined' ? true : bReadOnly;
+	bReadOnly = bReadOnly === 'undefined' ? true : bReadOnly;
 	for (let i = 0, n = aTextareas.length; i < n; i++)
 	{
 		aTextareas[i].readOnly = bReadOnly;
 	}
-
 	// If in a second the form is not gone, there may be a problem somewhere
 	// (e.g. HTML5 required attribute), so release the textarea
 	window.setTimeout(function() {