From abf256c336799c8bd6d98fd18dd2c97e1dbc96b4 Mon Sep 17 00:00:00 2001
From: Javed Habib <100477031+JaeAeich@users.noreply.github.com>
Date: Tue, 30 Jan 2024 17:54:08 +0530
Subject: [PATCH] fix: missing required asterisk (#225)

---
 .../src/components/tes-create-run/create-run.ts | 17 ++++++++---------
 .../src/components/form/form.ts                 |  8 +++++---
 2 files changed, 13 insertions(+), 12 deletions(-)

diff --git a/packages/ecc-client-lit-ga4gh-tes/src/components/tes-create-run/create-run.ts b/packages/ecc-client-lit-ga4gh-tes/src/components/tes-create-run/create-run.ts
index 653bea05..4c0f123a 100644
--- a/packages/ecc-client-lit-ga4gh-tes/src/components/tes-create-run/create-run.ts
+++ b/packages/ecc-client-lit-ga4gh-tes/src/components/tes-create-run/create-run.ts
@@ -81,6 +81,11 @@ export class TESCreateRun extends LitElement {
       key: "executors",
       label: "Executors",
       type: "group",
+      fieldOptions: {
+        required: true,
+        tooltip:
+          "A sequence of program arguments to execute, where the first argument is the program to execute (i.e. argv).",
+      },
       groupOptions: {
         collapsible: true,
       },
@@ -89,9 +94,6 @@ export class TESCreateRun extends LitElement {
           key: "executors",
           label: "",
           type: "array",
-          fieldOptions: {
-            required: true,
-          },
           arrayOptions: {
             defaultInstances: 1,
             min: 1,
@@ -103,6 +105,8 @@ export class TESCreateRun extends LitElement {
               type: "array",
               fieldOptions: {
                 required: true,
+                tooltip:
+                  "A sequence of program arguments to execute, where the first argument is the program to execute (i.e. argv).",
               },
               arrayOptions: {
                 defaultInstances: 1,
@@ -111,13 +115,8 @@ export class TESCreateRun extends LitElement {
               children: [
                 {
                   key: "command",
-                  label: "Command",
+                  label: "",
                   type: "text",
-                  fieldOptions: {
-                    required: true,
-                    tooltip:
-                      "A sequence of program arguments to execute, where the first argument is the program to execute (i.e. argv).",
-                  },
                 },
               ],
             },
diff --git a/packages/ecc-utils-design/src/components/form/form.ts b/packages/ecc-utils-design/src/components/form/form.ts
index 2f4a3fdb..6989818e 100644
--- a/packages/ecc-utils-design/src/components/form/form.ts
+++ b/packages/ecc-utils-design/src/components/form/form.ts
@@ -291,13 +291,13 @@ export default class EccUtilsDesignForm extends LitElement {
             ? html`
                 <sl-tooltip content=${field.fieldOptions?.tooltip}>
                   <label part="${label} ${arrayLabel}" class="array-label">
-                    ${field.label}
+                    ${field.label} ${field.fieldOptions?.required ? "*" : ""}
                   </label>
                 </sl-tooltip>
               `
             : html`
                 <label part="${label} ${arrayLabel}" class="array-label">
-                  ${field.label}
+                  ${field.label} ${field.fieldOptions?.required ? "*" : ""}
                 </label>
               `}
           <sl-button
@@ -398,7 +398,9 @@ export default class EccUtilsDesignForm extends LitElement {
     return html` <div class="group-container">
       ${field.groupOptions?.collapsible
         ? html` <sl-details
-            summary=${field.label}
+            summary=${`${field.label} ${
+              field.fieldOptions?.required ? "*" : ""
+            }`}
             exportparts="base: ${groupBase}, header: ${groupHeader}, header: ${header}, summary: ${label}, summary: ${groupLabel}, summary-icon: ${groupToggleIcon}, content: ${groupContent}"
           >
             ${renderChildren()}