Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): use helios 0.5.4 && enable rustls #594

Merged
merged 7 commits into from
Feb 26, 2024
Merged

chore(deps): use helios 0.5.4 && enable rustls #594

merged 7 commits into from
Feb 26, 2024

Conversation

sergey-melnychuk
Copy link
Contributor

@sergey-melnychuk sergey-melnychuk commented Feb 23, 2024

Use Helios 0.5.4 (tag) instead of raw commit.
Add rustls feature to reqwest (closes #555).

Extra:

@sergey-melnychuk
Copy link
Contributor Author

Confirming that this PR closes #555. With mimtproxy, a proxied call to Starknet fails:

{"jsonrpc":"2.0","error":{"code":-32601,"message":"error sending request for url (https://starknet-mainnet.g.alchemy.com/v2/<snip>): error trying to connect: error:0A000086:SSL routines:tls_post_process_server_certificate:certificate verify failed:ssl/statem/statem_clnt.c:2091: (unable to get local issuer certificate)"},"id":0}

Still unclear how exactly #555 was reproduced.

@sergey-melnychuk sergey-melnychuk merged commit db528f0 into main Feb 26, 2024
4 checks passed
@sergey-melnychuk sergey-melnychuk deleted the sm/v branch February 26, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: fix the mitm vulnerability of starknet client
2 participants