Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(550): Implement block hashing #589

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Conversation

pierre-l
Copy link
Contributor

@pierre-l pierre-l commented Feb 8, 2024

Issue Number: Related to #550

Type

  • feature
  • bugfix
  • dev (no functional changes, no API changes)
  • fmt (formatting, renaming)
  • build
  • docs
  • testing

Description

This implements block hashing as a preliminary step to #550. This was tested in starknet-rs but porting the test here will take more time and will be done in a separate PR.
This is one of the reasons why target branch of this PR is a feature branch.
The starknet-rs test can be previewed here

Breaking changes?

  • yes
  • no

@pierre-l pierre-l marked this pull request as ready for review February 8, 2024 10:33
Copy link
Contributor

@sergey-melnychuk sergey-melnychuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pierre-l pierre-l merged commit 2011845 into 550_proven_root_prototype Feb 9, 2024
4 checks passed
@pierre-l pierre-l deleted the block_hash branch February 9, 2024 14:45
@pierre-l pierre-l mentioned this pull request Feb 12, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants