Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checklist for Java new level bringup #17901

Open
JasonFengJ9 opened this issue Aug 2, 2023 · 5 comments
Open

Checklist for Java new level bringup #17901

JasonFengJ9 opened this issue Aug 2, 2023 · 5 comments

Comments

@JasonFengJ9
Copy link
Member

JasonFengJ9 commented Aug 2, 2023

The Next Java new level is Java 23.

@sophia-guo
Copy link
Contributor

Add jvmtitests excludes XML file for Java new level

This could be unnecessary by adding a makefile under https://github.com/eclipse-openj9/openj9/tree/master/test/functional/cmdLineTests/jvmtitests similar to variables.mk by setting excludelist for jdk8 jvmtitests_excludes_80.xml and jdk11+ as general one jvmtitests_excludes.xml. As all jvmtitests_excludes_11+.xml seems exactly same and suppose it should be same for newer versions. And add the makefile to playlist <include>../makefile</include>

@sophia-guo
Copy link
Contributor

Add TestConfig latest exclude file for Java new level

Technically this could also be unnecessary if preferred. Checking if EXCLUDE_FILE:=$(TEST_ROOT)$(D)TestConfig$(D)resources$(D)excludes$(D)$(JCL_VERSION)exclude$(JDK_VERSION).txt exists or not. Only export if available or not empty string. Testng extended util

public class IncludeExcludeTestAnnotationTransformer implements IAnnotationTransformer {
static private ArrayList<ExcludeData> excludeDatas = new ArrayList<ExcludeData>();
private static final Logger logger = Logger.getLogger(IncludeExcludeTestAnnotationTransformer.class);
static {
String line = null;
String excludeFilesEnv = System.getenv("EXCLUDE_FILE");
logger.info("EXCLUDE_FILE environment variable: " + excludeFilesEnv);
if (excludeFilesEnv != null) {
supports NULL environment, which won't break the test job.

@sophia-guo
Copy link
Contributor

Add openjdk/excludes/ProblemList_openjdk-openj9 file for Java new level

Adoptium would remove that requirement for hotspot. adoptium/aqa-tests#5932

@JasonFengJ9
Copy link
Member Author

FYI @llxia

@llxia
Copy link
Contributor

llxia commented Jan 31, 2025

Just for the record, the enhancement issue is opened at adoptium/aqa-tests#5890

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants