Skip to content

Commit 775e4b9

Browse files
authored
fix WebTerminal e2e tests (#23271)
1 parent 8f466ad commit 775e4b9

File tree

3 files changed

+17
-14
lines changed

3 files changed

+17
-14
lines changed

tests/e2e/pageobjects/webterminal/WebTerminalPage.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ export class WebTerminalPage {
173173
}
174174

175175
async clickOnTimeUnitDropDown(): Promise<void> {
176-
await this.driverHelper.waitAndClick(WebTerminalPage.TIME_UNIT_DROP_DAWN);
176+
await this.driverHelper.scrollToAndClick(WebTerminalPage.TIME_UNIT_DROP_DAWN);
177177
}
178178
async selectTimeUnit(timeUnits: TimeUnits): Promise<void> {
179179
await this.driverHelper.waitAndClick(By.xpath(`//button[@data-test-id='dropdown-menu' and text()='${timeUnits}']`));

tests/e2e/specs/web-terminal/WebTerminalUnderAdmin.spec.ts

+15-13
Original file line numberDiff line numberDiff line change
@@ -66,18 +66,17 @@ suite(`Login to Openshift console and start WebTerminal ${BASE_TEST_CONSTANTS.TE
6666
expect(commandResult).contains('admin');
6767
});
6868
test('Verify help command under admin user', async function (): Promise<void> {
69-
const helpCommandExpectedResult: string =
70-
'oc.*\\d+\\.\\d+\\.\\d+.*OpenShift CLI\n' +
71-
'kubectl.*\\d+\\.\\d+\\.\\d+.*Kubernetes CLI\n' +
72-
'kustomize.*\\d+\\.\\d+\\.\\d+.*Kustomize CLI\n' +
73-
'helm.*\\d+\\.\\d+\\.\\d+.*Helm CLI\n' +
74-
'kn.*\\d+\\.\\d+\\.\\d+.*KNative CLI\n' +
75-
'tkn.*\\d+\\.\\d+\\.\\d+.*Tekton CLI\n' +
76-
'subctl.*\\d+\\.\\d+\\.\\d+.*Submariner CLI\n' +
77-
'odo.*\\d+\\.\\d+\\.\\d+.*Red Hat OpenShift Developer CLI\n' +
78-
'virtctl.*\\d+\\.\\d+\\.\\d+.*KubeVirt CLI\n' +
79-
'rhoas.*\\d+\\.\\d+\\.\\d+.*Red Hat OpenShift Application Services CLI\n' +
80-
'jq.*\\d+\\.\\d+.*jq';
69+
const expectedStrings: string[] = [
70+
'OpenShift CLI',
71+
'Kubernetes CLI',
72+
'Kustomize CLI (built-in to kubectl)',
73+
'Helm CLI',
74+
'KNative CLI',
75+
'Tekton CLI',
76+
'Submariner CLI',
77+
'KubeVirt CLI',
78+
'jq'
79+
];
8180

8281
await webTerminal.typeAndEnterIntoWebTerminal(`help > ${fileForVerificationTerminalCommands}`);
8382

@@ -87,7 +86,10 @@ suite(`Login to Openshift console and start WebTerminal ${BASE_TEST_CONSTANTS.TE
8786
`cat /home/user/${fileForVerificationTerminalCommands}`,
8887
webTerminalToolContainerName
8988
);
90-
expect(commandResult).to.match(new RegExp(helpCommandExpectedResult));
89+
90+
expectedStrings.forEach((expectedString): void => {
91+
expect(commandResult).to.contain(expectedString);
92+
});
9193
});
9294

9395
test('Verify help command under admin user', async function (): Promise<void> {

tests/e2e/specs/web-terminal/WebTerminalUnderRegularUser.spec.ts

+1
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ suite(`Login to Openshift console and check WebTerminal ${BASE_TEST_CONSTANTS.TE
3737

3838
suiteSetup(function (): void {
3939
kubernetesCommandLineToolsExecutor.loginToOcp();
40+
kubernetesCommandLineToolsExecutor.deleteProject(testProjectName);
4041
});
4142

4243
suiteTeardown(function (): void {

0 commit comments

Comments
 (0)