-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite taxon menu as component-based menu #210
Open
synrg
wants to merge
14
commits into
main
Choose a base branch
from
PR-taxon-menu
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Dronefly frequently exceeds Discord's rate limit for edits to uncached messages due to members reacting to uncached messages. - As time passes and a conversation moves on, the value of further reactions on older messages diminish, as many people are no longer paying attention to those messages. - Therefore, this change disables reactions on uncached messages. - This will cause an inconvenience when the bot has been newly restarted, as any interactions started before the reload will no longer respond to reactions after the reload. - This could be remedied in subsequent commits by saving/reloading any unexpired interactions when the cog unloads/loads.
- Taxonomy button can be pressed by known users - Cancel button can be pressed by owner only - No place/user support yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modernizes the taxon menu, bringing it up to the same standards and look-and-feel as our model
,life
and,taxon list
commands. All menu, source, and formatter concerns are split off and moved down to dronefly-discord and dronefly-core as needed. When complete, it will finally resolve #141 .Concepts
Tasks