-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-evaluate the conditions on when to run scenario-tests in the VMR #4844
Comments
@mmitche @jkoritzinsky what do you think about this one? Should we run scenario-tests i.e. when target is win-x86 but host is win-x64? The emulation layer should handle these scenario for most OSs? |
I would say if the environment allows for the executable to run, then we should run it. |
I would tend to agree. Let's try to get coverage across multiple RIDs if we can. |
I wonder how to best approach this. I could try changing the condition to not apply to Windows and macOS initially. |
It might also be interesting to run the tests in Helix at some point if we want full coverage. Don't know if that's worth the effort at this time though. |
Here's an interesting example: dotnet/sdk#46399 (comment) |
https://github.com/dotnet/sdk/blob/3fd282535bfcdf58f6090b0a7ee63cac7b3fd788/src/SourceBuild/content/test/tests.proj#L6-L17
scenario-tests currently don't run on i.e. win-x86 as it uses a win-x64 host SDK. I wonder if we are missing coverage by that and should re-evaluate these conditions.
The text was updated successfully, but these errors were encountered: