Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBCData requires knowledge of the source branch of dependency flow #4843

Open
mmitche opened this issue Jan 23, 2025 · 2 comments
Open

IBCData requires knowledge of the source branch of dependency flow #4843

mmitche opened this issue Jan 23, 2025 · 2 comments

Comments

@mmitche
Copy link
Member

mmitche commented Jan 23, 2025

When IBC data is enabled in roslyn, it looks up the opiimization data based on the source branch that is being built, and finds the most relevant data. This means if we're building 17.4, it'll go find the 17.4 data.

This won't work in the VMR since the source branch wouldn't match roslyn's branches. We will somehow need to know and expose the source branch of flow to the build in these cases.

@premun
Copy link
Member

premun commented Jan 24, 2025

Can we just mandate that they have the version stored in a file on the branch and change it when they snap?

@mmitche
Copy link
Member Author

mmitche commented Jan 24, 2025

We could, but my guess is that it will be wrong at times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

3 participants