Fix src and dest namespace handling in clone table operation

Closes apache#5324

Author: dlmarion

server/manager/src/main/java/org/apache/accumulo/manager/FateServiceHandler.java

@@ -286,20 +286,26 @@ public void executeFateOperation(TInfo tinfo, TCredentials c, long opid, FateOpe
           keepOffline = Boolean.parseBoolean(ByteBufferUtil.toString(arguments.get(2)));
         }
 
+        NamespaceId srcNamespaceId;
         NamespaceId namespaceId;
         try {
+          srcNamespaceId = manager.getContext().getNamespaceId(srcTableId);
           namespaceId = Namespaces.getNamespaceId(manager.getContext(),
               TableNameUtil.qualify(tableName).getFirst());
         } catch (NamespaceNotFoundException e) {
           // shouldn't happen, but possible once cloning between namespaces is supported
           throw new ThriftTableOperationException(null, tableName, tableOp,
               TableOperationExceptionType.NAMESPACE_NOTFOUND, "");
+        } catch (TableNotFoundException e) {
+          // shouldn't happen, but possible once cloning between namespaces is supported
+          throw new ThriftTableOperationException(srcTableId.canonical(), null, tableOp,
+              TableOperationExceptionType.NOTFOUND, "");
         }
 
         final boolean canCloneTable;
         try {
           canCloneTable =
-              manager.security.canCloneTable(c, srcTableId, tableName, namespaceId, namespaceId);
+              manager.security.canCloneTable(c, srcTableId, tableName, namespaceId, srcNamespaceId);
         } catch (ThriftSecurityException e) {
           throwIfTableMissingSecurityException(e, srcTableId, null, TableOperation.CLONE);
           throw e;
@@ -336,9 +342,9 @@ public void executeFateOperation(TInfo tinfo, TCredentials c, long opid, FateOpe
           goalMessage += " and keep offline.";
         }
 
-        manager.fate().seedTransaction(
-            op.toString(), opid, new TraceRepo<>(new CloneTable(c.getPrincipal(), namespaceId,
-                srcTableId, tableName, propertiesToSet, propertiesToExclude, keepOffline)),
+        manager.fate().seedTransaction(op.toString(), opid,
+            new TraceRepo<>(new CloneTable(c.getPrincipal(), srcNamespaceId, srcTableId,
+                namespaceId, tableName, propertiesToSet, propertiesToExclude, keepOffline)),
             autoCleanup, goalMessage);
 
         break;

server/manager/src/main/java/org/apache/accumulo/manager/tableOps/clone/CloneTable.java

@@ -34,15 +34,17 @@ public class CloneTable extends ManagerRepo {
   private static final long serialVersionUID = 1L;
   private final CloneInfo cloneInfo;
 
-  public CloneTable(String user, NamespaceId namespaceId, TableId srcTableId, String tableName,
-      Map<String,String> propertiesToSet, Set<String> propertiesToExclude, boolean keepOffline) {
+  public CloneTable(String user, NamespaceId srcNamespaceId, TableId srcTableId,
+      NamespaceId namespaceId, String tableName, Map<String,String> propertiesToSet,
+      Set<String> propertiesToExclude, boolean keepOffline) {
     cloneInfo = new CloneInfo();
     cloneInfo.user = user;
     cloneInfo.srcTableId = srcTableId;
     cloneInfo.tableName = tableName;
     cloneInfo.propertiesToExclude = propertiesToExclude;
     cloneInfo.propertiesToSet = propertiesToSet;
-    cloneInfo.srcNamespaceId = namespaceId;
+    cloneInfo.srcNamespaceId = srcNamespaceId;
+    cloneInfo.namespaceId = namespaceId;
     cloneInfo.keepOffline = keepOffline;
   }