Nova 4 Support #37
Closed
Nova 4 Support #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dillingham Don't want to seem impatient here, just gonna ask now to avoid disappointment down the line: Are you still maintaining this repo and plan to merge and publish this in the near future or should we rather move on with a fork? Thanks a lot! |
|
Thx u a lot it works fine ! |
|
Seems like this is kind of abandoned for now. If anybody is looking for a working Nova 4 version, here is our fork with this PR applied and used in production by us already: |
|
Would be very happy if you can review this PR @dillingham? Thanks in advance! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the code to work with Nova 4. Fixes #36
IMPORTANT: Because of the heavy changes from Nova 3 to 4 (i.e. Vue 1 -> 3, Vue Router -> Inertia) this will break compatibility with Nova 3, so maybe release a separate major version for this.
Besides the updates to the new environment this also includes:
See it in action below:
Let me know if breaks anything else.