From bec3d58479f36b71d6a35ce7e911cbe9802fafbc Mon Sep 17 00:00:00 2001
From: Merlin Pannewitz <merlin.pannewitz@digitalservice.bund.de>
Date: Mon, 10 Feb 2025 15:42:53 +0100
Subject: [PATCH] Move some hardcoded strings to content.ts

---
 packages/dito/app/resources/content.ts                   | 9 +++++++++
 packages/dito/app/routes/methoden_.fuenf-prinzipien.tsx  | 8 ++++++--
 .../dito/app/routes/vorpruefung.$questionId/route.tsx    | 4 ++--
 packages/dito/app/routes/vorpruefung._index.tsx          | 4 ++--
 packages/dito/app/routes/vorpruefung.hinweise.tsx        | 4 ++--
 packages/tool-finder/src/routes/Flowchart.tsx            | 3 ++-
 6 files changed, 23 insertions(+), 9 deletions(-)

diff --git a/packages/dito/app/resources/content.ts b/packages/dito/app/resources/content.ts
index fb1dccc6..9b9a4f5f 100644
--- a/packages/dito/app/resources/content.ts
+++ b/packages/dito/app/resources/content.ts
@@ -56,6 +56,15 @@ export const header = {
     "Dieses Angebot befindet sich im Aufbau und wird auf Basis Ihrer Rückmeldung weiterentwickelt.",
 };
 
+export const general = {
+  buttonBack: {
+    text: "Zurück",
+  },
+  tableOfContents: {
+    headline: "Inhalt",
+  },
+};
+
 const stepNKR = {
   headline: {
     text: "Prüfen durch den NKR",
diff --git a/packages/dito/app/routes/methoden_.fuenf-prinzipien.tsx b/packages/dito/app/routes/methoden_.fuenf-prinzipien.tsx
index b2d65ca4..a1df14b4 100644
--- a/packages/dito/app/routes/methoden_.fuenf-prinzipien.tsx
+++ b/packages/dito/app/routes/methoden_.fuenf-prinzipien.tsx
@@ -12,7 +12,7 @@ import {
   useLoaderData,
 } from "@remix-run/react";
 import SupportBanner from "components/SupportBanner";
-import { fivePrinciples } from "resources/content";
+import { fivePrinciples, general } from "resources/content";
 import {
   ROUTE_EXAMPLES,
   ROUTE_METHODS,
@@ -74,7 +74,11 @@ export default function FivePrinciples() {
             }}
           />
           <div className="mt-64">
-            <Heading tagName="div" text="Inhalt" className="font-bold" />
+            <Heading
+              tagName="div"
+              text={general.tableOfContents.headline}
+              className="font-bold"
+            />
             <ol className="list-unstyled ds-stack-8 mt-16">
               {fivePrinciples.principles.map((principle) => (
                 <li key={principle.label}>
diff --git a/packages/dito/app/routes/vorpruefung.$questionId/route.tsx b/packages/dito/app/routes/vorpruefung.$questionId/route.tsx
index 3a3014f5..a6465a30 100644
--- a/packages/dito/app/routes/vorpruefung.$questionId/route.tsx
+++ b/packages/dito/app/routes/vorpruefung.$questionId/route.tsx
@@ -11,7 +11,7 @@ import { useForm, validationError } from "@rvf/remix";
 import { withZod } from "@rvf/zod";
 import LinkBar from "components/LinkBar";
 import { useEffect, useState } from "react";
-import { preCheck } from "resources/content";
+import { general, preCheck } from "resources/content";
 import { ROUTE_PRECHECK } from "resources/staticRoutes";
 import {
   getAnswersFromCookie,
@@ -200,7 +200,7 @@ export default function Index() {
                 },
                 {
                   id: "preCheck-back-button",
-                  text: "Zurück",
+                  text: general.buttonBack.text,
                   href: question.prevLink,
                   look: "tertiary",
                 },
diff --git a/packages/dito/app/routes/vorpruefung._index.tsx b/packages/dito/app/routes/vorpruefung._index.tsx
index 874bbc8e..0619b22a 100644
--- a/packages/dito/app/routes/vorpruefung._index.tsx
+++ b/packages/dito/app/routes/vorpruefung._index.tsx
@@ -11,7 +11,7 @@ import type { MetaFunction } from "@remix-run/react";
 import Accordion from "components/Accordion";
 import SupportBanner from "components/SupportBanner";
 import { PRE_CHECK_START_BUTTON_ID } from "resources/constants";
-import { preCheck } from "resources/content";
+import { general, preCheck } from "resources/content";
 import {
   ROUTE_GENERAL_INFO,
   ROUTE_LANDING,
@@ -59,7 +59,7 @@ export default function Index() {
               },
               {
                 id: "preCheck-back-button",
-                text: "Zurück",
+                text: general.buttonBack.text,
                 href: ROUTE_LANDING.url,
                 look: "tertiary",
               },
diff --git a/packages/dito/app/routes/vorpruefung.hinweise.tsx b/packages/dito/app/routes/vorpruefung.hinweise.tsx
index d92b3b85..c80c3cd5 100644
--- a/packages/dito/app/routes/vorpruefung.hinweise.tsx
+++ b/packages/dito/app/routes/vorpruefung.hinweise.tsx
@@ -5,7 +5,7 @@ import InlineNotice from "@digitalcheck/shared/components/InlineNotice";
 import RichText from "@digitalcheck/shared/components/RichText";
 import { type LoaderFunctionArgs } from "@remix-run/node";
 import { type MetaFunction, useLoaderData } from "@remix-run/react";
-import { preCheck } from "resources/content";
+import { general, preCheck } from "resources/content";
 import { ROUTE_GENERAL_INFO, ROUTE_PRECHECK } from "resources/staticRoutes";
 import { getAnswersFromCookie } from "utils/cookies.server";
 import prependMetaTitle from "utils/metaTitle";
@@ -54,7 +54,7 @@ export default function GeneralInfo() {
               },
               {
                 id: "generalInfo-back-button",
-                text: "Zurück",
+                text: general.buttonBack.text,
                 href: ROUTE_PRECHECK.url,
                 look: "tertiary",
               },
diff --git a/packages/tool-finder/src/routes/Flowchart.tsx b/packages/tool-finder/src/routes/Flowchart.tsx
index c59088ef..6077df39 100644
--- a/packages/tool-finder/src/routes/Flowchart.tsx
+++ b/packages/tool-finder/src/routes/Flowchart.tsx
@@ -4,6 +4,7 @@ import Container from "@digitalcheck/shared/components/Container";
 import Header from "@digitalcheck/shared/components/Header";
 import useTitle from "services/useTitle";
 
+import { general } from "@digitalcheck/dito/app/resources/content";
 import Button from "@digitalcheck/shared/components/Button";
 import Image from "@digitalcheck/shared/components/Image";
 import flowchartElementsImage from "resources/img/flowchart-elements.png";
@@ -103,7 +104,7 @@ Der Start mag Ihnen leichter fallen, wenn Sie als Basis eine zeitliche Abfolge w
       <Container className="pb-48 pt-0">
         <Button
           id="flowchart-guide-page-back-button"
-          text="Zurück"
+          text={general.buttonBack.text}
           href={PATH_RESULT}
         />
       </Container>