New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve webhook handler #2

Open

muzzwood opened this issue Mar 13, 2021 · 0 comments

Collaborator

muzzwood commented Mar 13, 2021

Turns out that Omise will send a request to the registered webhook for ANY transaction. Regardless of whether the method requires a webhook.

For the methods that don't use a webhook, errors are being generated in the log because the wrong payment method id is used as the get param.

https://github.com/digitalpenguin/Commerce_Omise/blob/master/core/components/commerce_omise/src/Gateways/PromptPay.php#L72

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment