diff --git a/.changeset/chilled-icons-chew.md b/.changeset/chilled-icons-chew.md new file mode 100644 index 0000000000..b87eb3cd88 --- /dev/null +++ b/.changeset/chilled-icons-chew.md @@ -0,0 +1,5 @@ +--- +"@digdir/designsystemet-react": patch +--- + +Accordion: Fix `defaultOpen` flicker on first render diff --git a/packages/react/src/utilities/AnimateHeight/AnimateHeight.test.tsx b/packages/react/src/utilities/AnimateHeight/AnimateHeight.test.tsx index 42f45e40e3..216ba0688e 100644 --- a/packages/react/src/utilities/AnimateHeight/AnimateHeight.test.tsx +++ b/packages/react/src/utilities/AnimateHeight/AnimateHeight.test.tsx @@ -35,7 +35,7 @@ describe('AnimateHeight', () => { it('Appends given style to root element', () => { const style = { color: 'rgb(255, 0, 0)' }; const { container } = render({ style }); - expect(container.firstChild).toHaveStyle({ height: 0 }); + expect(container.firstChild).toHaveStyle({ height: undefined }); expect(container.firstChild).toHaveStyle(style); }); diff --git a/packages/react/src/utilities/AnimateHeight/AnimateHeight.tsx b/packages/react/src/utilities/AnimateHeight/AnimateHeight.tsx index d58afe84f1..d79f4efb96 100644 --- a/packages/react/src/utilities/AnimateHeight/AnimateHeight.tsx +++ b/packages/react/src/utilities/AnimateHeight/AnimateHeight.tsx @@ -22,7 +22,10 @@ export const AnimateHeight = ({ style, ...rest }: AnimateHeightProps) => { - const [height, setHeight] = useState(0); + /* We don't know the initial height we want to start with. + It depends on if it should start open or not, therefore we set height to `undefined`, + so we don't get any layoutshift on first render */ + const [height, setHeight] = useState(undefined); const prevOpen = usePrevious(open); const openOrClosed: InternalState = open ? 'open' : 'closed'; const [state, setState] = useState(openOrClosed);