-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility test on all components #2355
Labels
♿️ accessibility
Issues related to accessibility
Comments
eirikbacker
added a commit
that referenced
this issue
Sep 10, 2024
Barsnes
pushed a commit
that referenced
this issue
Sep 11, 2024
This was referenced Sep 12, 2024
mimarz
pushed a commit
that referenced
this issue
Jan 14, 2025
mimarz
pushed a commit
that referenced
this issue
Feb 21, 2025
mimarz
pushed a commit
that referenced
this issue
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Accordion
Navigation and Screen reader
Zoom
Color and contrast
Misc (All fixed)
Alert
Guidelines
aria-live
and moving focus is documented in storybook (This might be handled by the systemerrors)role="alert"
? Should this be the default?Screen reader
Contrast
Zoom
Misc (fixed)
Badge
Screen reader
role="img"
and makearia-label
prop required see discussionContrast
Zoom
Breadcrumbs
Navigation
Screen reader
nav
Contrast
Zoom
Misc
breadcrumbs
#2747Button
Navigation
Contrast
Screen reader
Zoom
Misc
Card
Screen reader
linkcard
the important link text should be the first element that is read. (Added a note to misc about this)Navigation
Zoom
Misc
as
should beas child
figcaption
to imageCheckbox
Navigation
spacebar
Screen reader
Contrast
Zoom
Misc
aria-disabled
on read-only checkboxes. (read only is not announced by screen reader)Chips
TODO - After #2321
Combobox
Consider using U-elements U-tags Our multiselect is not usable with screen readers as is. It might be better to use our resources into U-elements instead of continue on our own component
Divider
No WCAG requirements
Misc
Dropdown
Screen reader
Zoom
Misc
Error-summary
Misc
aria-relevant="all"
andaria-live="polite"
are redundantetabindex= "-1"
so that you can move focus to the summaryFieldset
Misc
HelpText
Zoom
px
. This should change torem
to support text scalingNavigation
aria-hidden="true"
to avoid announcing "dialog with 2 items"role="dialog"
as this causes an extra screen reader stop where helptext title is announced again, instead of accessing helptext contentMisc
aria-label
instead ofspan class="ds-sr-only"
for label textLink
Zoom
Skeleton
Misc
Spinner
Misc
Modal
Zoom
max-height
from browser which we should overwrite)rem
and notpx
to allow text only zoomScreen reader
aria-label
oraria-labelledby
ondialog
elementaria-label
on close button (nottitle
), and usearia-hidden
on inner SVGautoFocus
regardless of form fields? (works on anything that can receive focus)x
before heading so screen reader users does not skip the heading elementNativeSelect
Not much to test on this component. Do zoom and screen reader tests.Screen reader
Misc
mutliple select
example from storybookSelect
Pagination
Not much to test on this component. Do zoom and screen reader tests.Zoom
Screen reader
aria-current="page"
aria-hidden="true"
Navigate between datasets
etc.Documentation
Misc
&ellipsis;
instead of...
to get the correct ellipsis from fontitemLabel
to become just a string?Popover
Zoom
px
. This should change torem
to support text scalingNavigation
aria-hidden="true"
to avoid announcing "dialog with 2 items"role="dialog"
as this causes an extra screen reader stop instead of announcing contentRadio
Same as Checkbox:
Navigation
spacebar
Screen reader
Contrast
Zoom
Misc
aria-disabled
on read-only checkboxes. (read only is not announced by screen reader)Search
Misc
SkipLink
Works like a charm ❤️
Switch
aria-disabled
on read-only checkboxes. (read only is not announced by screen reader)Table
Misc
role
to all elements to elements to ensure we always have table behavior regardless ofdisplay
(oftendisplay: flex
is used on tables to achieve responsive approaches)? (see https://adrianroselli.com/2018/05/functions-to-add-aria-to-tables-and-lists.html)Table.HeaderCell
havesort?: true | 'none' | 'ascending' | 'descending'}
instead of having a separatesortable
property to avoid confusion and more 1:1 api witharia-sort
?Tabs
Zoom
Misc
tabindex="0"
on tablistrole="tabpanel"
around panelsTags
Zoom
Textarea
**Misc** Very nice implementation of counter ❤️ - Can remove redundant `aria-relevant` - Can add `field-sizing: content` for better user experience when typing multiple linesToggleGroup
Zoom
Misc
tabindex="0"
onrole="radiogroup"
aria-checked
, aka. removearia-current
Tooltip
Screen reader
aria-description
instead ofaria-describedby
to allow access to tooltip when navigating in forms modearia-hidden="true"
to tooltip box to prevent redundant announcementMisc
Tasks
The text was updated successfully, but these errors were encountered: