Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review Group components for V1 #2331

Closed
eirikbacker opened this issue Aug 27, 2024 · 3 comments
Closed

Review Group components for V1 #2331

eirikbacker opened this issue Aug 27, 2024 · 3 comments
Assignees
@eirikbacker
Labels
css @digdir/designsystemet-css 🕵️ investigate Needs investigation react @digdir/designsystemet-react
Milestone
V1 - Lansering

Comments

@eirikbacker
Copy link
Contributor

ButtonGroup (missing today but located in Figma), ChipGroup, TagGroup, etc - they are really just simple display: flex containers (super easy to implement). I think we should perhaps remove ChipGroup from our code for now since it is the only component that offers such a container, and it could actually in the future might be better to use a shared Primitive component rather than individual components replicating code? In our current documentation, we for instance have examples of buttons next to each other, without providing a ButtonGroup component, so for consistency, I suggest we allow ourselves to do the same on Chip as well. What do you think? ☺
@eirikbacker eirikbacker converted this from a draft issue Aug 27, 2024
@eirikbacker eirikbacker added the css @digdir/designsystemet-css label Aug 27, 2024
@mrosvik mrosvik added this to the V1 - Helhetlig komponentbibliotek milestone Aug 30, 2024
@eirikbacker
Copy link
Contributor Author

Related to #2321

@eirikbacker eirikbacker self-assigned this Aug 30, 2024
@mrosvik mrosvik added 🕵️ investigate Needs investigation react @digdir/designsystemet-react labels Aug 30, 2024
@mrosvik mrosvik changed the title Remove ChipGroup from code for V1? Review Group components for V1 Sep 19, 2024
@mimarz
Copy link
Collaborator

mimarz commented Sep 19, 2024

Related to #2304

@eirikbacker
Copy link
Contributor Author

Concluded in Daily 24.09.24: Closing this as it is will not be needed if doing #2492 as we

@github-project-automation github-project-automation bot moved this from 📄 Todo to ✅ Done in Team Designsystemet Sep 25, 2024
@mrosvik mrosvik modified the milestones: Helhetlig komponentbibliotek, V1 - Lansering Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eirikbacker eirikbacker

Labels
css @digdir/designsystemet-css 🕵️ investigate Needs investigation react @digdir/designsystemet-react
Projects
Team Designsystemet
Status: ✅ Done
Milestone
V1 - Lansering
Development

No branches or pull requests
3 participants
@eirikbacker @mimarz @mrosvik