Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breakpoints #2119

Open
1 of 5 tasks
mimarz opened this issue Jun 10, 2024 · 2 comments
Open
1 of 5 tasks

Breakpoints #2119

mimarz opened this issue Jun 10, 2024 · 2 comments
Labels
☂️ epic Issues ready 🧭 roadmap Used in roadmap

Comments

@mimarz
Copy link
Collaborator

mimarz commented Jun 10, 2024

We need to define what our breakpoints are and define them as tokens so we can export them as css variables (even if media queries doens't support it yet) and make a page documententing usage.

Suggest keep using the same name we have for sizes to keep consistency.

Old breakpoint tokens: https://github.com/digdir/designsystemet/tree/main/design-tokens/Viewport

Notes:

Tasks

Preview Give feedback
  1. ♿️ accessibility 🐛 bug 🖥️ storefront
    Barsnes
  2. documentation/guidelines
@mimarz mimarz converted this from a draft issue Jun 10, 2024
@mimarz mimarz added the ☂️ epic Issues ready label Jun 10, 2024
@mimarz
Copy link
Collaborator Author

mimarz commented Jun 10, 2024

Decided to try these breakpoints

Size em px
xs 40em 640px
s 48em 768px
m 64em 1024px
l 80em 1280px
xl 96em 1536px

Suggested naming

--ds-breakpoint-xs
--ds-breakpoint-s
--ds-breakpoint-m
--ds-breakpoint-l
--ds-breakpoint-xl

@mimarz mimarz moved this from 🔵 Inbox to ☂ Epics in Team Designsystemet Jun 10, 2024
@Camulos
Copy link
Contributor

Camulos commented Aug 22, 2024

Seem like there is a lot of users that use resolutions close to the minimums mentioned in WCAG (320px width). There is also something strange about the stats and most likely there is some pollution in the source-data used in Statcounter. I think the smallest size need to work from minimum 320 px, but we do not need to test for usability at smaller screens than 320.
https://gs.statcounter.com/screen-resolution-stats/all/norway

Would be interesting to see comparable results from some public service websites.

At BR we do not track viewport at the moment as this is not gathered on the server-side statistics that we get (in Kibana). However, I have asked for operation system and browser stats.

@Febakke Febakke added this to the V1 - Helhetlig dokumentasjon milestone Aug 29, 2024
This was referenced Sep 25, 2024
@mrosvik mrosvik added the 🧭 roadmap Used in roadmap label Jan 20, 2025
@mimarz mimarz moved this from ☂ Todo Epics to 📋 Backlog in Team Designsystemet Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
☂️ epic Issues ready 🧭 roadmap Used in roadmap
Projects
Status: No status
Status: 📋 Backlog
Development

No branches or pull requests

4 participants