Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC: Field component #1943

Closed
Tracked by #2311
mimarz opened this issue May 3, 2024 · 1 comment · Fixed by #2502
Closed
Tracked by #2311

POC: Field component #1943

mimarz opened this issue May 3, 2024 · 1 comment · Fixed by #2502
Assignees
Labels
🕵️ investigate Needs investigation react @digdir/designsystemet-react

Comments

@mimarz
Copy link
Collaborator

mimarz commented May 3, 2024

Create a proof of concept pattern in React and CSS for generic container components for common form elements.

Some designsystems use generic form classes, usually called form-group for their form components to have consistent placement of label, descriptions and such around an input/textarea/select element.

Do we want to use this approach? Pros and cons?

Notes:

@mimarz mimarz added the css @digdir/designsystemet-css label May 3, 2024
@mimarz mimarz changed the title Should we have Form Group classes? Should we have form-group classes? May 3, 2024
@mimarz mimarz moved this from 🔵 Inbox to 📋 Backlog in Team Designsystemet May 3, 2024
@eirikbacker
Copy link
Contributor

Egentlig det samme som vi snakker om i #2221 og #2311

@mimarz mimarz added this to the V1 - Helhetlig komponentbibliotek milestone Sep 24, 2024
@mimarz mimarz changed the title Should we have form-group classes? POC: Field component Sep 25, 2024
@mimarz mimarz added the react @digdir/designsystemet-react label Sep 25, 2024
@mimarz mimarz moved this from 📋 Backlog to 📄 Todo in Team Designsystemet Sep 25, 2024
@github-project-automation github-project-automation bot moved this from 📄 Todo to ✅ Done in Team Designsystemet Sep 25, 2024
@eirikbacker eirikbacker reopened this Sep 25, 2024
@github-project-automation github-project-automation bot moved this from ✅ Done to 🔵 Inbox in Team Designsystemet Sep 25, 2024
@eirikbacker eirikbacker moved this from 🔵 Inbox to 🏗 In progress in Team Designsystemet Sep 25, 2024
@mrosvik mrosvik added the 🕵️ investigate Needs investigation label Sep 30, 2024
@eirikbacker eirikbacker added react @digdir/designsystemet-react and removed react @digdir/designsystemet-react css @digdir/designsystemet-css labels Sep 30, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Team Designsystemet Oct 18, 2024
@mrosvik mrosvik modified the milestones: Helhetlig komponentbibliotek, V1 - Lansering Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕵️ investigate Needs investigation react @digdir/designsystemet-react
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants