Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal autoFocus sometimes not working #1177

Closed
Barsnes opened this issue Dec 1, 2023 · 3 comments · Fixed by #2440
Closed

Modal autoFocus sometimes not working #1177

Barsnes opened this issue Dec 1, 2023 · 3 comments · Fixed by #2440
Labels
♿️ accessibility Issues related to accessibility 🐛 bug Something isn't working 🕵️ investigate Needs investigation react @digdir/designsystemet-react
Milestone
V1 - Lansering

Comments

@Barsnes
Copy link
Member

Barsnes commented Dec 1, 2023 •
edited
Loading

Description of the bug

There are occurrences of autoFocus not working. This needs further investigation.
@jensmo98 discovered this issue, and might be able to provide more information.

First issue covering this bug was #1116

Steps To Reproduce

Use modal with autoFocus set

Additional Information

No response
@Barsnes Barsnes added the 🐛 bug Something isn't working label Dec 1, 2023
This was referenced Dec 1, 2023
Merged
Closed
@mimarz mimarz added the react @digdir/designsystemet-react label Dec 4, 2023
@mimarz mimarz moved this from 🔵 Inbox to 📄 Todo in Team Designsystemet Dec 4, 2023
@mimarz mimarz added the 🕵️ investigate Needs investigation label Dec 4, 2023
@mrosvik
Copy link
Member

mrosvik commented Jan 30, 2024

@Barsnes Do we know more about this issue?

@Barsnes
Copy link
Member Author

Barsnes commented Jan 30, 2024

@Barsnes Do we know more about this issue?

Nothing new has been found yet

@mrosvik mrosvik added the ♿️ accessibility Issues related to accessibility label Sep 19, 2024
@mrosvik mrosvik added this to the V1 - Helhetlig komponentbibliotek milestone Sep 19, 2024
@eirikbacker eirikbacker mentioned this issue Sep 25, 2024
Merged
@eirikbacker
Copy link
Contributor

This can happen due to the entrance animation on Modal, it is fixed in #2440

@eirikbacker eirikbacker moved this from 📄 Todo to 👀 Ready for review in Team Designsystemet Sep 25, 2024
@github-project-automation github-project-automation bot moved this from 👀 Ready for review to ✅ Done in Team Designsystemet Sep 25, 2024
@mrosvik mrosvik modified the milestones: Helhetlig komponentbibliotek, V1 - Lansering Jan 28, 2025
mimarz pushed a commit that referenced this issue Feb 21, 2025
@eirikbacker @Barsnes @mimarz
fix(Modal): api alignment (#2440)
36c52e8 
- **Question for review:** Should `Modal.Close` be a compound component?
🤔
- Fixes #2063
- Fixes #1177

---------

Co-authored-by: barsnes <tobias.barsnes@digdir.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
♿️ accessibility Issues related to accessibility 🐛 bug Something isn't working 🕵️ investigate Needs investigation react @digdir/designsystemet-react
Projects
Team Designsystemet
Status: ✅ Done
Milestone
V1 - Lansering
Development

Successfully merging a pull request may close this issue.

fix(Modal): api alignment digdir/designsystemet
4 participants
@eirikbacker @mimarz @mrosvik @Barsnes