Skip to content

Commit 76ebeef

Browse files
Fix: Check for all of vizkit3d, vizkit3d_debug_drawings libraries
The debug drawings are marked optional, so we must check for all of them, vizkit3d-qt5 and vizkit3d(qt4 version) can be absent depending on the version of vizkit3d being compiled or settings in vizkit3d, independent of the presence of Qt4 or Qt5.
1 parent e121bea commit 76ebeef

File tree

3 files changed

+55
-20
lines changed

3 files changed

+55
-20
lines changed

CMakeLists.txt

+12-4
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,20 @@ project(ugv_nav4d
88
set(CMAKE_CXX_STANDARD 14)
99
set(CMAKE_CXX_STANDARD_REQUIRED ON)
1010

11+
find_package(Rock)
12+
rock_init()
13+
rock_feature(NOCURDIR)
14+
15+
pkg_check_modules(vizkit3d_debug_drawings-commands vizkit3d_debug_drawings-commands)
16+
1117
if(ENABLE_DEBUG_DRAWINGS)
1218
message(STATUS "ENABLE_DEBUG_DRAWINGS is defined with value: ${ENABLE_DEBUG_DRAWINGS}")
13-
add_definitions(-DENABLE_DEBUG_DRAWINGS)
19+
if(vizkit3d_debug_drawings-commands_FOUND)
20+
add_definitions(-DENABLE_DEBUG_DRAWINGS)
21+
message(STATUS "Building with vizkit3d_debug_drawings support in library")
22+
else()
23+
message(STATUS "Cannot find vizkit3d_debug_drawings, ignoring ENABLE_DEBUG_DRAWINGS")
24+
endif()
1425
else()
1526
message(STATUS "ENABLE_DEBUG_DRAWINGS is set to OFF. Skipped!")
1627
endif()
@@ -25,7 +36,4 @@ if(INSTALL_DEPS)
2536
set(ENV{CMAKE_PREFIX_PATH} ${CMAKE_INSTALL_PREFIX}/share/rock/cmake/)
2637
endif()
2738

28-
find_package(Rock)
29-
rock_init()
30-
rock_feature(NOCURDIR)
3139
rock_standard_layout()

src/CMakeLists.txt

+1-4
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,8 @@ set(DEPS_PKGCONFIG_LIST
1313
trajectory_follower
1414
)
1515

16-
if (ENABLE_DEBUG_DRAWINGS)
16+
if(ENABLE_DEBUG_DRAWINGS AND vizkit3d_debug_drawings-commands_FOUND)
1717
list(APPEND DEPS_PKGCONFIG_LIST vizkit3d_debug_drawings-commands)
18-
# These are (only) required for building the GUIs:
19-
list(APPEND DEPS_PKGCONFIG_QT4 vizkit3d_debug_drawings)
20-
list(APPEND DEPS_PKGCONFIG_QT5 vizkit3d_debug_drawings-qt5)
2118
endif()
2219

2320
rock_library(ugv_nav4d

src/gui/CMakeLists.txt

+42-12
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,28 @@
11
rock_find_qt4(OPTIONAL)
22
rock_find_qt5(OPTIONAL)
33

4+
pkg_check_modules(vizkit3d vizkit3d)
5+
pkg_check_modules(vizkit3d-qt5 vizkit3d-qt5)
6+
7+
pkg_check_modules(vizkit3d_debug_drawings vizkit3d_debug_drawings)
8+
pkg_check_modules(vizkit3d_debug_drawings-qt5 vizkit3d_debug_drawings-qt5)
9+
410
find_package(PCL 1.7 REQUIRED COMPONENTS common io)
511
IF("${PCL_VERSION_MAJOR}.${PCL_VERSION_MINOR}" VERSION_LESS 1.14)
612
SET(PCL_VERSION_SUFFIX "-${PCL_VERSION_MAJOR}.${PCL_VERSION_MINOR}")
713
ENDIF()
814

9-
if(ROCK_QT_VERSION_4)
15+
if(ENABLE_DEBUG_DRAWINGS AND vizkit3d_debug_drawings-commands_FOUND)
16+
# These are (only) required for building the GUIs:
17+
if(vizkit3d_debug_drawings_FOUND)
18+
list(APPEND DEPS_PKGCONFIG_QT4 vizkit3d_debug_drawings)
19+
endif()
20+
if(vizkit3d_debug_drawings-qt5_FOUND)
21+
list(APPEND DEPS_PKGCONFIG_QT5 vizkit3d_debug_drawings-qt5)
22+
endif()
23+
endif()
24+
25+
if(ROCK_QT_VERSION_4 AND vizkit3d_FOUND)
1026
rock_library(ugv_nav4d_gui
1127
SOURCES
1228
PlannerGui.cpp
@@ -28,21 +44,28 @@ if(ROCK_QT_VERSION_4)
2844
)
2945

3046
rock_executable(ugv_nav4d_bin
31-
SOURCES
32-
Main.cpp
33-
DEPS ugv_nav4d ugv_nav4d_gui
47+
SOURCES
48+
Main.cpp
49+
DEPS ugv_nav4d ugv_nav4d_gui
3450
)
3551

3652
rock_executable(ugv_nav4d_replay
37-
SOURCES
38-
ReplayDump.cpp
39-
DEPS ugv_nav4d ugv_nav4d_gui
40-
DEPS_PKGCONFIG vizkit3d maps-viz base-viz
41-
sbpl_spline_primitives-viz base-types trajectory_follower-viz
53+
SOURCES
54+
ReplayDump.cpp
55+
DEPS ugv_nav4d ugv_nav4d_gui
56+
DEPS_PKGCONFIG vizkit3d maps-viz base-viz
57+
sbpl_spline_primitives-viz base-types trajectory_follower-viz
4258
)
43-
endif(ROCK_QT_VERSION_4)
59+
if (ENABLE_DEBUG_DRAWINGS AND vizkit3d_debug_drawings-commands_FOUND AND vizkit3d_debug_drawings_FOUND)
60+
message(STATUS "Gui using Qt4: enabled, with debug drawings")
61+
else()
62+
message(STATUS "Gui using Qt4: enabled, without debug drawings")
63+
endif()
64+
else(ROCK_QT_VERSION_4 AND vizkit3d_FOUND)
65+
message(STATUS "Gui using Qt4: disabled")
66+
endif(ROCK_QT_VERSION_4 AND vizkit3d_FOUND)
4467

45-
if(ROCK_QT_VERSION_5)
68+
if(ROCK_QT_VERSION_5 AND vizkit3d-qt5_FOUND)
4669
rock_library(ugv_nav4d_gui-qt5
4770
SOURCES
4871
PlannerGui.cpp
@@ -76,4 +99,11 @@ if(ROCK_QT_VERSION_5)
7699
DEPS_PKGCONFIG vizkit3d-qt5 maps-viz-qt5 base-viz-qt5
77100
sbpl_spline_primitives-viz-qt5 base-types trajectory_follower-viz-qt5
78101
)
79-
endif(ROCK_QT_VERSION_5)
102+
if (ENABLE_DEBUG_DRAWINGS AND vizkit3d_debug_drawings-commands_FOUND AND vizkit3d_debug_drawings-qt5_FOUND)
103+
message(STATUS "Gui using Qt5: enabled, with debug drawings")
104+
else()
105+
message(STATUS "Gui using Qt5: enabled, without debug drawings")
106+
endif()
107+
else()
108+
message(STATUS "Gui using Qt5: disabled")
109+
endif(ROCK_QT_VERSION_5 AND vizkit3d-qt5_FOUND)

0 commit comments

Comments
 (0)