From 371af47e31e7bdd8c3c81699b98f79157d69487d Mon Sep 17 00:00:00 2001 From: Gaurav Saini <147703805+gauravsaini04@users.noreply.github.com> Date: Wed, 4 Sep 2024 05:43:32 +0000 Subject: [PATCH 1/3] [GO] - Add support for v1.23 --- src/go-postgres/README.md | 2 +- src/go-postgres/devcontainer-template.json | 6 ++++-- src/go/README.md | 2 +- src/go/devcontainer-template.json | 6 ++++-- 4 files changed, 10 insertions(+), 6 deletions(-) diff --git a/src/go-postgres/README.md b/src/go-postgres/README.md index 9e1bc510..4123f7b1 100644 --- a/src/go-postgres/README.md +++ b/src/go-postgres/README.md @@ -7,7 +7,7 @@ Use and develop Go + Postgres applications. Includes appropriate runtime args, G | Options Id | Description | Type | Default Value | |-----|-----|-----|-----| -| imageVariant | Go version: | string | 1.22-bookworm | +| imageVariant | Go version: | string | 1.23-bookworm | This template references an image that was [pre-built](https://containers.dev/implementors/reference/#prebuilding) to automatically include needed devcontainer.json metadata. diff --git a/src/go-postgres/devcontainer-template.json b/src/go-postgres/devcontainer-template.json index 989f932b..fe43cfcb 100644 --- a/src/go-postgres/devcontainer-template.json +++ b/src/go-postgres/devcontainer-template.json @@ -1,6 +1,6 @@ { "id": "go-postgres", - "version": "4.0.2", + "version": "4.0.3", "name": "Go & PostgreSQL", "description": "Use and develop Go + Postgres applications. Includes appropriate runtime args, Go, common tools, extensions, and dependencies.", "documentationURL": "https://github.com/devcontainers/templates/tree/main/src/go-postgres", @@ -12,13 +12,15 @@ "description": "Go version:", "proposals": [ "1-bookworm", + "1.23-bookworm", "1.22-bookworm", "1.21-bookworm", "1-bullseye", + "1.23-bullseye", "1.22-bullseye", "1.21-bullseye" ], - "default": "1.22-bookworm" + "default": "1.23-bookworm" } }, "platforms": ["Go"], diff --git a/src/go/README.md b/src/go/README.md index ff1a6ee7..321608e3 100644 --- a/src/go/README.md +++ b/src/go/README.md @@ -7,7 +7,7 @@ Develop Go based applications. Includes appropriate runtime args, Go, common too | Options Id | Description | Type | Default Value | |-----|-----|-----|-----| -| imageVariant | Go version: | string | 1.22-bookworm | +| imageVariant | Go version: | string | 1.23-bookworm | This template references an image that was [pre-built](https://containers.dev/implementors/reference/#prebuilding) to automatically include needed devcontainer.json metadata. diff --git a/src/go/devcontainer-template.json b/src/go/devcontainer-template.json index 27d58b16..921f3461 100644 --- a/src/go/devcontainer-template.json +++ b/src/go/devcontainer-template.json @@ -1,6 +1,6 @@ { "id": "go", - "version": "4.0.2", + "version": "4.0.3", "name": "Go", "description": "Develop Go based applications. Includes appropriate runtime args, Go, common tools, extensions, and dependencies.", "documentationURL": "https://github.com/devcontainers/templates/tree/main/src/go", @@ -12,13 +12,15 @@ "description": "Go version:", "proposals": [ "1-bookworm", + "1.23-bookworm", "1.22-bookworm", "1.21-bookworm", "1-bullseye", + "1.23-bullseye", "1.22-bullseye", "1.21-bullseye" ], - "default": "1.22-bookworm" + "default": "1.23-bookworm" } }, "platforms": ["Go"], From 4e13ce9b94135e9d25976475b8003c3c5b8b4749 Mon Sep 17 00:00:00 2001 From: Gaurav Saini <147703805+gauravsaini04@users.noreply.github.com> Date: Thu, 5 Sep 2024 08:52:02 +0000 Subject: [PATCH 2/3] changes --- src/go-postgres/devcontainer-template.json | 2 +- src/go/devcontainer-template.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/go-postgres/devcontainer-template.json b/src/go-postgres/devcontainer-template.json index fe43cfcb..e51946af 100644 --- a/src/go-postgres/devcontainer-template.json +++ b/src/go-postgres/devcontainer-template.json @@ -1,6 +1,6 @@ { "id": "go-postgres", - "version": "4.0.3", + "version": "4.1.0", "name": "Go & PostgreSQL", "description": "Use and develop Go + Postgres applications. Includes appropriate runtime args, Go, common tools, extensions, and dependencies.", "documentationURL": "https://github.com/devcontainers/templates/tree/main/src/go-postgres", diff --git a/src/go/devcontainer-template.json b/src/go/devcontainer-template.json index 921f3461..dfe2c9a7 100644 --- a/src/go/devcontainer-template.json +++ b/src/go/devcontainer-template.json @@ -1,6 +1,6 @@ { "id": "go", - "version": "4.0.3", + "version": "4.1.0", "name": "Go", "description": "Develop Go based applications. Includes appropriate runtime args, Go, common tools, extensions, and dependencies.", "documentationURL": "https://github.com/devcontainers/templates/tree/main/src/go", From 33d006f6de9787fc07a39e9d7a2f800cf194bda8 Mon Sep 17 00:00:00 2001 From: Gaurav Saini <147703805+gauravsaini04@users.noreply.github.com> Date: Tue, 10 Sep 2024 05:54:14 +0000 Subject: [PATCH 3/3] changes as wanted in pr review comments --- src/go-postgres/README.md | 2 +- src/go-postgres/devcontainer-template.json | 4 +--- src/go/README.md | 2 +- src/go/devcontainer-template.json | 4 +--- 4 files changed, 4 insertions(+), 8 deletions(-) diff --git a/src/go-postgres/README.md b/src/go-postgres/README.md index 4123f7b1..9e1bc510 100644 --- a/src/go-postgres/README.md +++ b/src/go-postgres/README.md @@ -7,7 +7,7 @@ Use and develop Go + Postgres applications. Includes appropriate runtime args, G | Options Id | Description | Type | Default Value | |-----|-----|-----|-----| -| imageVariant | Go version: | string | 1.23-bookworm | +| imageVariant | Go version: | string | 1.22-bookworm | This template references an image that was [pre-built](https://containers.dev/implementors/reference/#prebuilding) to automatically include needed devcontainer.json metadata. diff --git a/src/go-postgres/devcontainer-template.json b/src/go-postgres/devcontainer-template.json index e51946af..bd564f3a 100644 --- a/src/go-postgres/devcontainer-template.json +++ b/src/go-postgres/devcontainer-template.json @@ -14,11 +14,9 @@ "1-bookworm", "1.23-bookworm", "1.22-bookworm", - "1.21-bookworm", "1-bullseye", "1.23-bullseye", - "1.22-bullseye", - "1.21-bullseye" + "1.22-bullseye" ], "default": "1.23-bookworm" } diff --git a/src/go/README.md b/src/go/README.md index 321608e3..ff1a6ee7 100644 --- a/src/go/README.md +++ b/src/go/README.md @@ -7,7 +7,7 @@ Develop Go based applications. Includes appropriate runtime args, Go, common too | Options Id | Description | Type | Default Value | |-----|-----|-----|-----| -| imageVariant | Go version: | string | 1.23-bookworm | +| imageVariant | Go version: | string | 1.22-bookworm | This template references an image that was [pre-built](https://containers.dev/implementors/reference/#prebuilding) to automatically include needed devcontainer.json metadata. diff --git a/src/go/devcontainer-template.json b/src/go/devcontainer-template.json index dfe2c9a7..f9b760e7 100644 --- a/src/go/devcontainer-template.json +++ b/src/go/devcontainer-template.json @@ -14,11 +14,9 @@ "1-bookworm", "1.23-bookworm", "1.22-bookworm", - "1.21-bookworm", "1-bullseye", "1.23-bullseye", - "1.22-bullseye", - "1.21-bullseye" + "1.22-bullseye" ], "default": "1.23-bookworm" }