Skip to content

Commit 765a182

Browse files
committed
Get it hooked up correctly
Signed-off-by: Derek Ho <dxho@amazon.com>
1 parent 5cf5a09 commit 765a182

File tree

6 files changed

+15
-41
lines changed

6 files changed

+15
-41
lines changed

public/apps/account/cluster-selector.tsx

-29
This file was deleted.

public/apps/configuration/app-router.tsx

+4-4
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ import { ResourceType } from '../../../common';
4141
import { buildHashUrl, buildUrl } from './utils/url-builder';
4242
import { CrossPageToast } from './cross-page-toast';
4343
import { useOpenSearchDashboards } from '../../../../../src/plugins/opensearch_dashboards_react/public';
44-
import { TopNavMenu } from './top-nav-menu';
44+
import { SecurityPluginTopNavMenu, TopNavMenu } from './top-nav-menu';
4545

4646
const LANDING_PAGE_URL = '/getstarted';
4747

@@ -257,22 +257,22 @@ export function AppRouter(props: AppDependencies) {
257257
path={ROUTE_MAP.tenants.href}
258258
render={() => {
259259
setGlobalBreadcrumbs(ResourceType.tenants);
260-
return <><TopNavMenu dataSourcePickerReadOnly={true} {...props}/><TenantList tabID={'Manage'} {...props} /></>;
260+
return <><SecurityPluginTopNavMenu dataSourcePickerReadOnly={true} {...props}/><TenantList tabID={'Manage'} {...props} /></>;
261261
}}
262262
/>
263263
<Route
264264
path={ROUTE_MAP.tenantsConfigureTab.href}
265265
render={() => {
266266
setGlobalBreadcrumbs(ResourceType.tenants);
267267

268-
return <><TopNavMenu dataSourcePickerReadOnly={true} {...props}/><TenantList tabID={'Configure'} {...props} /></>;
268+
return <><SecurityPluginTopNavMenu dataSourcePickerReadOnly={true} {...props}/><TenantList tabID={'Configure'} {...props} /></>;
269269
}}
270270
/>
271271
<Route
272272
path={ROUTE_MAP.getStarted.href}
273273
render={() => {
274274
setGlobalBreadcrumbs();
275-
return (<><TopNavMenu {...props} dataSourcePickerReadOnly={false}/><GetStarted {...props} /></>);
275+
return (<><GetStarted {...props} /></>);
276276
}}
277277
/>
278278
<Redirect exact from="/" to={LANDING_PAGE_URL} />

public/apps/configuration/panels/get-started.tsx

+7-2
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ import {
2525
EuiText,
2626
EuiTitle,
2727
} from '@elastic/eui';
28-
import React from 'react';
28+
import React, { useState } from 'react';
2929
import { FormattedMessage } from '@osd/i18n/react';
3030
import { AppDependencies } from '../../types';
3131
import { buildHashUrl } from '../utils/url-builder';
@@ -34,6 +34,8 @@ import { ResourceType } from '../../../../common';
3434
import { API_ENDPOINT_CACHE, DocLinks } from '../constants';
3535
import { ExternalLink, ExternalLinkButton } from '../utils/display-utils';
3636
import { httpDelete } from '../utils/request-utils';
37+
import { SecurityPluginTopNavMenu, TopNavMenu } from '../top-nav-menu';
38+
import { setData } from 'src/plugins/vis_type_vega/public/services';
3739

3840
const addBackendStep = {
3941
title: 'Add backends',
@@ -157,6 +159,8 @@ const setOfSteps = [
157159
];
158160

159161
export function GetStarted(props: AppDependencies) {
162+
const [datasourceId, setDatasourceId] = useState(undefined);
163+
160164
let steps;
161165
if (props.config.ui.backend_configurable) {
162166
steps = [addBackendStep, ...setOfSteps];
@@ -167,6 +171,7 @@ export function GetStarted(props: AppDependencies) {
167171
return (
168172
<>
169173
<div className="panel-restrict-width">
174+
<SecurityPluginTopNavMenu {...props} dataSourcePickerReadOnly={false} random={setDatasourceId}/>
170175
<EuiPageHeader>
171176
<EuiTitle size="l">
172177
<h1>Get started</h1>
@@ -231,7 +236,7 @@ export function GetStarted(props: AppDependencies) {
231236
iconType="refresh"
232237
fill
233238
onClick={() => {
234-
httpDelete(props.coreStart.http, API_ENDPOINT_CACHE, {dataSourceId: '84e72d90-db00-11ee-baf1-55ab53c9cfb9'});
239+
httpDelete(props.coreStart.http, API_ENDPOINT_CACHE, {dataSourceId: datasourceId});
235240
}}
236241
>
237242
Purge cache

public/apps/configuration/top-nav-menu.tsx

+3-2
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,13 @@ import { AppDependencies } from '../types';
2222

2323
export interface TopNavMenuProps extends AppDependencies {
2424
dataSourcePickerReadOnly: boolean
25+
random: any;
2526
}
2627

27-
export const TopNavMenu = (props: TopNavMenuProps) => {
28+
export const SecurityPluginTopNavMenu = (props: TopNavMenuProps) => {
2829
const {securityPluginStartDeps, dataSourcePickerReadOnly, setHeaderActionMenu} = props;
2930
const TopNavMenu = securityPluginStartDeps.navigation.ui.TopNavMenu;
3031
const dataSourceEnabled = securityPluginStartDeps.dataSource.dataSourceEnabled;
3132

32-
return <TopNavMenu appName={PLUGIN_NAME} dataSourcePickerReadOnly={dataSourcePickerReadOnly} showDataSourcePicker={dataSourceEnabled} setMenuMountPoint={setHeaderActionMenu}/>
33+
return <TopNavMenu appName={PLUGIN_NAME} disableDataSourcePicker={dataSourcePickerReadOnly} showDataSourcePicker={dataSourceEnabled} setMenuMountPoint={setHeaderActionMenu} dataSourceCallBackFunc={props.random}/>
3334
}

public/plugin.ts

-2
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ import { addTenantToShareURL } from './services/shared-link';
5050
import { interceptError } from './utils/logout-utils';
5151
import { tenantColumn, getNamespacesToRegister } from './apps/configuration/utils/tenant-utils';
5252
import { getDashboardsInfoSafe } from './utils/dashboards-info-utils';
53-
import { setupClusterSelector } from './apps/account/cluster-selector';
5453

5554
async function hasApiPermission(core: CoreSetup): Promise<boolean | undefined> {
5655
try {
@@ -191,7 +190,6 @@ export class SecurityPlugin
191190
const config = this.initializerContext.config.get<ClientConfigType>();
192191

193192
setupTopNavButton(core, config);
194-
setupClusterSelector(core, deps);
195193

196194
if (config.ui.autologout) {
197195
// logout the user when getting 401 unauthorized, e.g. when session timed out.

server/routes/index.ts

+1-2
Original file line numberDiff line numberDiff line change
@@ -752,7 +752,7 @@ export function defineRoutes(router: IRouter, dataSourceEnabled: boolean) {
752752
}
753753
},
754754
async (context, request, response) => {
755-
if (!dataSourceEnabled) {
755+
if (!dataSourceEnabled || !request.body?.dataSourceId) {
756756
const client = context.security_plugin.esClient.asScoped(request);
757757
let esResponse;
758758
try {
@@ -766,7 +766,6 @@ export function defineRoutes(router: IRouter, dataSourceEnabled: boolean) {
766766
return errorResponse(response, error);
767767
}
768768
} else {
769-
console.log(request.body)
770769
const client = context.dataSource.opensearch.legacy.getClient(request.body?.dataSourceId);
771770
let esResponse;
772771
try{

0 commit comments

Comments
 (0)