Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review exported PDFs from "MHV Rx" team #66799

Closed
4 of 12 tasks
Tracked by #77076
vmenshutin-bylight opened this issue Oct 3, 2023 · 3 comments
Closed
4 of 12 tasks
Tracked by #77076

Review exported PDFs from "MHV Rx" team #66799

vmenshutin-bylight opened this issue Oct 3, 2023 · 3 comments

Comments

@vmenshutin-bylight
Copy link

vmenshutin-bylight commented Oct 3, 2023

What does your team need support for? Check all that apply.

  • Launching one or more unauthenticated pages, online forms, apps, or tools on VA.gov
  • Making revisions to one or more existing VA.gov pages
  • Something else

Give a brief description of what your team needs support with.

The "MHV Rx" team is making a new PDF template for Medications List and Medication Details pages. We need to review these samples to make sure the a11y requirements are being met as development proceeds.

Will this new product be released incrementally (for instance 25% of users initially)?

  • Yes
  • No

Supporting artifacts

Please provide supporting artifacts as available.

There are sample PDFs:

Non-VA-medications-details-Harry-Potter-10-03-2023_120911p.m..pdf
VA-medications-details-Harry-Potter-10-03-2023_120856p.m..pdf
VA-medications-list-Harry-Potter-10-03-2023_120617p.m..pdf

Will this work be going through the Collaboration Cycle?

  • Yes (eventually)
  • No

When does this work need to be done?

  • Estimated launch date:
  • Estimated staging review date:
  • Content, Accessibility, and IA work needed by: asap as developers are actively working

Do you plan to bring this to an upcoming content office hours session?

  • Yes, benefit content office hours (Thursdays, 3:00 p.m. to 3:45 p.m. ET)
  • Yes, health content office hours (Thursdays, 11:00 a.m. to 11:30 a.m. ET)
  • Yes, unauth office hours (Mondays, 11:00 a.m. to 11:30 a.m. ET)
  • No, but I'd like to schedule time to talk about this request
  • No, let's work asynchronously and meet if needed

Note: If we think this work would benefit from a collaborative session with you, we may ask you to bring it to office hours or set up a separate time to meet.

About your team

@SarahKay8
Copy link
Contributor

SarahKay8 commented Oct 6, 2023

💻🅰️Testing device: Acrobat Adobe

📄PDF review - Calamine lotion (First Doc)

Non-VA-medications-details-Harry-Potter-10-03-2023_120911p.m..pdf

  • Accessibility Checker Failure - Tab order failed - No interactive elements in doc, tab order won't really make a difference but it is failing accessibility checker. Not sure if possible to set in source software
  • Empty artifact tags in tag tree before each < H3 > of page. Starting on Page 2
  • Empty < H4 > tags after each < H3 > of page. Please delete these in tags tree. Starting on Page 2
  • Due to the lists taking on form of Definition lists, content in < P > tag underneath “Non-VA medications Include These Types:” needs to be made into a "List" Steps: Convert to a "< L >" Add an < LI > as a parent element inside < L > tag. Add children tags making “*” a < Lbl > and “prescriptions you filled…” in an < Lbody > tag etc... Page 1
    Screenshot for reference

📄PDF Review - Lactated Ringers (Second Doc)

VA-medications-details-Harry-Potter-10-03-2023_120856p.m..pdf

  • Failed tab order
  • Empty < artifact > tag before < H1 > in < sect > tag right before < H1 >. Page 1
  • Empty < H4 > tags after all < H3 >'s need to be removed Starting on page 2
  • Empty < artifact > tags before all < H3 >'s need to be removed. Starting on Page 2
  • Empty < artifact > tag needs to be removed after “quantity 1: “ < P > tag. Page 1

📄PDF Review Medications - Lactated Ringers (Third Doc)

VA-medications-list-Harry-Potter-10-03-2023_120617p.m..pdf

  • Tab order failed

  • Empty artifact tags before all **< H3 >**s (delete In tags tree) pages 1-7

  • Empty artifact tags before all < H4 >'s (delete in tags tree) page 8-9

  • First bulleted point section underneath “We may use this status for either of these reasons:” needs to be broken out of
    < P > tag and formatted into a List Page 10

  • Bulleted point section under “Nefazodone 100MG Tab” needs to be made into a List Page 10
    Screenshot for reference

  • Empty **< artifact > **tags before < H3 > need to be removed from tags tree. Pages 10-12

Allergies section

  • Empty < H4 > tag after all < H3 >’s needs to be removed from tags tree Pages 13-17
  • Empty < artifact > tags after all **< H3 >**s needs to be removed from tags tree Pages 13-17

Overall Feedback on all PDF(s)

  • Provide content for Subject fields in Metadata
  • < Sect > tags are used as root elements. < Document > should be used as the tag that contains all tags in tag tree.
  • Overall Heading Hierarchy is good to go

Header/Footer Issue to be aware of

  • Tagged < artifact > header and footer content at end of tag tree is read by screenreaders when users enter end of document. If it isn't possible to progammatically ignore header/footer in source, could alt text be added to properties of the artifacted content to let users know it should be ignored?

Header/Footer feedback from Evan B. "It would be best to find a way to make sure header/footer content isn't read at all. If this is content is important and should be read, only one instance of the header/footer should be accessed - the header on the the first page and the footer on the last page. This is the ideal scenario. It seems like the app is trying to make the header/footer content hidden from users due to the tags, but it's still picked up. Since they come at the end of the document, it doesn't impact the user much, so I'd be okay leaving as is if there's no way to address the issue."

cc: @vmenshutin-bylight @BobbyBaileyRB @artsymartha68

If there is any thing I missed or if I need to clarify anything, lmk

@acrollet
Copy link
Contributor

acrollet commented Oct 6, 2023

Regarding tab order, we're waiting on a patch to get merged to the upstream package: foliojs/pdfkit#1449

@SarahKay8 SarahKay8 modified the milestone: Collaboration Cycle for Accredited Representation Management #65707 Oct 10, 2023
@SarahKay8
Copy link
Contributor

@acrollet Closing as a Jira Ticket has been created. Slack thread here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants