DLPX-93498 LTS 24.04: Warning generated due to missing header declaring struct iscsi_conn

[palash-gandhi]

Problem

estat and stbtrace Blackbox tests fail because warnings are written to stderr
and Blackbox treats those as errors:

09:27:48  dlpx-os-upgrade-qar-164571-766f97e2.dcol2.delphix.com: sudo -- timeout --preserve-status --signal=SIGINT 30 estat iscsi 15
09:28:11  02/26/25 - 17:27:53 UTC
09:28:11  
09:28:11   Tracing enabled... Hit Ctrl-C to end.
09:28:11  Caught error while executing command: sudo -- timeout --preserve-status --signal=SIGINT 30 estat iscsi 15
09:28:11  /virtual/main.c:99:48: warning: declaration of 'struct iscsi_conn' will not be visible outside of this function [-Wvisibility]
09:28:11     99 | iscsi_target_start(struct pt_regs *ctx, struct iscsi_conn *conn,
09:28:11        |                                                ^
09:28:11  /virtual/main.c:127:51: warning: declaration of 'struct iscsi_conn' will not be visible outside of this function [-Wvisibility]
09:28:11    127 | iscsi_target_response(struct pt_regs *ctx, struct iscsi_conn *conn, struct iscsit_cmd *cmd, int state)
09:28:11        |                                                   ^
09:28:11  2 warnings generated.
...
...
09:32:51  blackbox.exceptions.BlackboxAssertionError: The following estat subcommands failed to execute successfully: ['iscsi']: Expected ['iscsi'] to be empty

The struct is defined in scsi/libiscsi.h

Solution

Include it.

Testing Done

Modified the script on a 24.04 engine and verified that the warnings are no longer present:

delphix@localhost:~$ cat /usr/share/performance-diagnostics/bpf/estat/iscsi.c | grep libiscsi
#include <scsi/libiscsi.h>

delphix@localhost:~$ sudo estat iscsi 15
02/26/25 - 18:13:07 UTC

 Tracing enabled... Hit Ctrl-C to end.
delphix@localhost:~$