Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Prometheus Collector for Pot #2

Open
ddaws opened this issue Mar 4, 2020 · 1 comment
Open

Implement Prometheus Collector for Pot #2

ddaws opened this issue Mar 4, 2020 · 1 comment
Assignees
@ddaws
Labels
enhancement New feature or request

Comments

@ddaws
Copy link
Owner

ddaws commented Mar 4, 2020 •
edited
Loading

A Prometheus Collector collect stats on the MCD Pot contract. The Collect method of the collector will be called on every metrics collections from Prometheus. I propose naming metrics like mcd_pot_.... For all contract we can add metrics as mcd_<contract>_<metric>.

You can take a look at an example collector responsible for collecting metrics on Ethereum block headers here: https://github.com/ddaws/maker-monitor/blob/master/monitor/collector/header.go

Please use go-maker which supports accessing the Pot
@ddaws ddaws added the enhancement New feature or request label Mar 4, 2020
@ddaws ddaws self-assigned this Mar 10, 2020
@ddaws
Copy link
Owner Author

ddaws commented Mar 10, 2020

I've implement a lot of this now. I'll consider this complete when I am able to visualize Pot metrics in Grafana which makes this issue dependent on adding support for Grafana

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ddaws ddaws

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ddaws