sql-parser: minor test updates on test-dataset

Author: Almaz-KG

src/parser/mod.rs

@@ -78,7 +78,6 @@ impl<'a> Parser<'a> {
     /// If the current token's type does not match, a [ParsingError::UnexpectedToken] is thrown.
     fn consume_as_string(&mut self) -> Result<(), ParsingError> {
         let token = self.peek_token()?;
-        dbg!(&token);
         if let TokenType::String(_) = token.token_type {
             self.consume_token()?;
             Ok(())

tests/bart-riers-sqlite-dataset/README.md

@@ -2,7 +2,7 @@
 
 The test dataset is taken from the [Bart Kiers' SQLite ANTLR parser](https://github.com/bkiers/sqlite-parser/tree/master).
 
-In the current implementation, there is 65.33% of the tests that are passing.
+In the current implementation, there is 61.86% of the tests that are passing.
 By passing tests, I mean that the parser successfully parses the SQL query and returns a valid `Expression` AST.
 The structure of the parsed AST is not checked, as there are no expected ASTs list
 

tests/bart-riers-sqlite-dataset/main.rs

@@ -19,9 +19,8 @@ fn run_bart_riers_sqlite_dataset_test() {
         let path = entry.path();
 
         if path.extension().and_then(|ext| ext.to_str()) == Some("sql") {
-            let parsing_result = std::panic::catch_unwind(|| run_test(&path));
-
-            if parsing_result.is_ok() && parsing_result.unwrap() {
+            let parsing_result = run_test(&path);
+            if parsing_result {
                 passed_test += 1;
             }
         }
@@ -38,8 +37,6 @@ fn run_bart_riers_sqlite_dataset_test() {
         "Passed {:.2}% of the tests",
         (passed_test as f64 / total_tests as f64) * 100.0
     );
-
-    // assert_eq!(passed_test, total_tests);
 }
 
 /// Run a single test and return true if the test passes, false otherwise

tests/codeschool-sqlite-parser-test-files/README.md

@@ -3,4 +3,4 @@
 The queries under `sql/` folder are taken from the [Codeschool SQLite Parser](https://github.com/codeschool/sqlite-parser/tree/master) repository.
 
 
-Current test pass rate is 38.33%
+Current test pass rate is 37.74%

tests/codeschool-sqlite-parser-test-files/main.rs

@@ -20,9 +20,8 @@ fn run_codeschool_sqlite_parser_test() {
 
             if file.extension().and_then(|ext| ext.to_str()) == Some("sql") {
                 let sql_content = fs::read_to_string(file).expect("Failed to read file");
-                let parsing_result = std::panic::catch_unwind(|| run_test(&sql_content));
-
-                if parsing_result.is_ok() && parsing_result.unwrap() {
+                let parsing_result = run_test(&sql_content);
+                if parsing_result {
                     passed_test += 1;
                 }
                 total_tests += 1;