@@ -27,18 +27,15 @@ pub trait SelectStatementParser {
27
27
28
28
fn parse_select_column ( & mut self ) -> Result < SelectItem , ParsingError > ;
29
29
30
- fn parse_select_from_clause ( & mut self ) -> Result < Option < FromClause > , ParsingError > ;
30
+ fn parse_from_clause ( & mut self ) -> Result < Option < FromClause > , ParsingError > ;
31
31
32
- fn parse_select_from_clause_subquery ( & mut self ) -> Result < FromClause , ParsingError > ;
32
+ fn parse_from_clause_subquery ( & mut self ) -> Result < FromClause , ParsingError > ;
33
33
34
- fn parse_select_from_join_clause (
35
- & mut self ,
36
- lhs : FromClause ,
37
- ) -> Result < FromClause , ParsingError > ;
34
+ fn parse_from_join_clause ( & mut self , lhs : FromClause ) -> Result < FromClause , ParsingError > ;
38
35
39
- fn parse_select_from_clause_join_type ( & mut self ) -> Result < JoinType , ParsingError > ;
36
+ fn parse_from_clause_join_type ( & mut self ) -> Result < JoinType , ParsingError > ;
40
37
41
- fn parse_select_from_clause_join_constraints (
38
+ fn parse_from_clause_join_constraints (
42
39
& mut self ,
43
40
) -> Result < Option < JoinConstraint > , ParsingError > ;
44
41
@@ -92,7 +89,7 @@ impl<'a> SelectStatementParser for Parser<'a> {
92
89
Ok ( SelectStatement :: Select ( Select {
93
90
distinct_type : self . parse_distinct_type ( ) ?,
94
91
columns : self . parse_select_columns ( ) ?,
95
- from : self . parse_select_from_clause ( ) ?,
92
+ from : self . parse_from_clause ( ) ?,
96
93
where_clause : self . parse_where_clause ( ) ?,
97
94
group_by : self . parse_group_by_clause ( ) ?,
98
95
having : self . parse_having_clause ( ) ?,
@@ -157,15 +154,15 @@ impl<'a> SelectStatementParser for Parser<'a> {
157
154
) )
158
155
}
159
156
160
- fn parse_select_from_clause ( & mut self ) -> Result < Option < FromClause > , ParsingError > {
157
+ fn parse_from_clause ( & mut self ) -> Result < Option < FromClause > , ParsingError > {
161
158
if let Ok ( Keyword :: From ) = self . peek_as_keyword ( ) {
162
159
self . consume_as_keyword ( Keyword :: From ) ?;
163
- return Ok ( Some ( self . parse_select_from_clause_subquery ( ) ?) ) ;
160
+ return Ok ( Some ( self . parse_from_clause_subquery ( ) ?) ) ;
164
161
}
165
162
Ok ( None )
166
163
}
167
164
168
- fn parse_select_from_clause_subquery ( & mut self ) -> Result < FromClause , ParsingError > {
165
+ fn parse_from_clause_subquery ( & mut self ) -> Result < FromClause , ParsingError > {
169
166
dbg ! ( "parse_select_from_clause" ) ;
170
167
171
168
dbg ! ( & self . peek_token( ) ) ;
@@ -186,7 +183,7 @@ impl<'a> SelectStatementParser for Parser<'a> {
186
183
let mut froms = Vec :: new ( ) ;
187
184
loop {
188
185
dbg ! ( "parse_select_from_clause" ) ;
189
- let table_or_subquery = self . parse_select_from_clause_subquery ( ) ?;
186
+ let table_or_subquery = self . parse_from_clause_subquery ( ) ?;
190
187
dbg ! ( & table_or_subquery) ;
191
188
froms. push ( table_or_subquery) ;
192
189
@@ -224,7 +221,7 @@ impl<'a> SelectStatementParser for Parser<'a> {
224
221
indexed_type,
225
222
} ) ;
226
223
227
- return self . parse_select_from_join_clause ( lhs) ;
224
+ return self . parse_from_join_clause ( lhs) ;
228
225
}
229
226
}
230
227
// TODO: improve this error message
@@ -233,19 +230,16 @@ impl<'a> SelectStatementParser for Parser<'a> {
233
230
) )
234
231
}
235
232
236
- fn parse_select_from_join_clause (
237
- & mut self ,
238
- lhs : FromClause ,
239
- ) -> Result < FromClause , ParsingError > {
233
+ fn parse_from_join_clause ( & mut self , lhs : FromClause ) -> Result < FromClause , ParsingError > {
240
234
dbg ! ( "parse_select_from_join_clause" ) ;
241
235
let mut join_tables = Vec :: new ( ) ;
242
236
243
- while let Ok ( join_type) = self . parse_select_from_clause_join_type ( ) {
244
- let rhs = self . parse_select_from_clause_subquery ( ) ?;
237
+ while let Ok ( join_type) = self . parse_from_clause_join_type ( ) {
238
+ let rhs = self . parse_from_clause_subquery ( ) ?;
245
239
join_tables. push ( JoinTable {
246
240
join_type,
247
241
table : Box :: new ( rhs) ,
248
- constraints : self . parse_select_from_clause_join_constraints ( ) ?,
242
+ constraints : self . parse_from_clause_join_constraints ( ) ?,
249
243
} ) ;
250
244
}
251
245
@@ -259,7 +253,7 @@ impl<'a> SelectStatementParser for Parser<'a> {
259
253
} ) )
260
254
}
261
255
262
- fn parse_select_from_clause_join_type ( & mut self ) -> Result < JoinType , ParsingError > {
256
+ fn parse_from_clause_join_type ( & mut self ) -> Result < JoinType , ParsingError > {
263
257
let natural_join = self . consume_as_keyword ( Keyword :: Natural ) . is_ok ( ) ;
264
258
265
259
if self . consume_as ( TokenType :: Comma ) . is_ok ( ) {
@@ -316,7 +310,7 @@ impl<'a> SelectStatementParser for Parser<'a> {
316
310
}
317
311
}
318
312
319
- fn parse_select_from_clause_join_constraints (
313
+ fn parse_from_clause_join_constraints (
320
314
& mut self ,
321
315
) -> Result < Option < JoinConstraint > , ParsingError > {
322
316
if self . consume_as_keyword ( Keyword :: On ) . is_ok ( ) {
0 commit comments