sql_parser: create statement tests refactoring

Author: Almaz-KG

src/parser/create/create_index.rs

@@ -64,36 +64,32 @@ pub mod test_utils {
 }
 
 #[cfg(test)]
-mod test_create_index_statement_parser {
-    use test_utils::create_index_statement;
-
+mod create_index_tests {
+    use super::test_utils::create_index_statement;
+    use crate::expression::test_utils::{
+        binary_op_expression, identifier_expression, numeric_literal_expression,
+    };
     use crate::{
-        expression::test_utils::{
-            binary_op_expression, identifier_expression, numeric_literal_expression,
-        },
-        parser::test_utils::run_sunny_day_test,
-        BinaryOp, Identifier, IndexedColumn, Statement,
+        parser::test_utils::run_sunny_day_test, BinaryOp, Identifier, IndexedColumn, Statement,
     };
 
-    use super::*;
-
     #[test]
-    fn test_parse_create_index_statement() {
+    fn create_index_test() {
         let sql = "CREATE INDEX index_name ON table_name (column1)";
         let expected = create_index_statement();
         run_sunny_day_test(sql, Statement::CreateIndex(expected));
     }
 
     #[test]
-    fn test_parse_create_unique_index_statement() {
+    fn create_unique_index() {
         let sql = "CREATE UNIQUE INDEX index_name ON table_name (column1)";
         let mut expected = create_index_statement();
         expected.unique = true;
         run_sunny_day_test(sql, Statement::CreateIndex(expected));
     }
 
     #[test]
-    fn test_parse_create_index_statement_with_schema() {
+    fn create_index_with_schema() {
         let sql = "CREATE INDEX schema_name.index_name ON table_name (column1)";
         let mut expected = create_index_statement();
         expected.index_name =
@@ -102,7 +98,7 @@ mod test_create_index_statement_parser {
     }
 
     #[test]
-    fn test_parse_create_index_statement_with_multiple_columns() {
+    fn create_index_with_multiple_columns() {
         let sql = "CREATE INDEX index_name ON table_name (column1, column2, column3, column4)";
         let mut expected = create_index_statement();
         expected.columns = vec![
@@ -127,15 +123,15 @@ mod test_create_index_statement_parser {
     }
 
     #[test]
-    fn test_parse_create_index_statement_with_if_not_exists() {
+    fn create_index_with_if_not_exists() {
         let sql = "CREATE INDEX IF NOT EXISTS index_name ON table_name (column1)";
         let mut expected = create_index_statement();
         expected.if_not_exists = true;
         run_sunny_day_test(sql, Statement::CreateIndex(expected));
     }
 
     #[test]
-    fn test_parse_create_index_statement_with_where_clause() {
+    fn create_index_with_where_clause() {
         let sql = "CREATE INDEX index_name ON table_name (column1) WHERE column1 = 1";
         let mut expected = create_index_statement();
         expected.where_clause = Some(Box::new(binary_op_expression(

src/parser/create/create_table.rs

@@ -200,7 +200,7 @@ pub mod test_utils {
 }
 
 #[cfg(test)]
-mod test_create_table_statement_parser {
+mod create_table_tests {
     use crate::{
         expression::test_utils::identifier_expression, parser::test_utils::run_sunny_day_test,
         ColumnConstraint, ColumnConstraintType, ColumnDefinition, ConflictClause,
@@ -211,7 +211,7 @@ mod test_create_table_statement_parser {
     use super::test_utils::create_table_statement;
 
     #[test]
-    fn test_parse_create_table_statement() {
+    fn create_table_test() {
         let expected_stmt = create_table_statement();
         run_sunny_day_test(
             "CREATE TABLE table_name AS SELECT * FROM table_name",
@@ -220,7 +220,7 @@ mod test_create_table_statement_parser {
     }
 
     #[test]
-    fn test_parse_create_temporary_table_statement() {
+    fn create_temporary_table_test() {
         let mut expected_stmt = create_table_statement();
         expected_stmt.temporary = true;
 
@@ -236,7 +236,7 @@ mod test_create_table_statement_parser {
     }
 
     #[test]
-    fn test_parse_create_table_statement_with_if_not_exists() {
+    fn create_table_with_if_not_exists() {
         let mut expected_stmt = create_table_statement();
         expected_stmt.if_not_exists = true;
 
@@ -247,7 +247,7 @@ mod test_create_table_statement_parser {
     }
 
     #[test]
-    fn test_parse_create_table_statement_with_schema() {
+    fn create_table_with_schema() {
         let mut expected_stmt = create_table_statement();
         expected_stmt.table_name =
             Identifier::Compound(vec!["schema_name".to_string(), "table_name".to_string()]);
@@ -258,7 +258,7 @@ mod test_create_table_statement_parser {
     }
 
     #[test]
-    fn test_parse_create_table_statement_with_column_definitions() {
+    fn create_table_with_column_definitions() {
         let mut expected_stmt = create_table_statement();
         expected_stmt.create_table_option =
             CreateTableOption::ColumnDefinitions(CreateTableColumnDef {
@@ -291,7 +291,7 @@ mod test_create_table_statement_parser {
     }
 
     #[test]
-    fn test_parse_create_table_statement_with_table_constraints() {
+    fn create_table_with_table_constraints() {
         let mut expected_stmt = create_table_statement();
         expected_stmt.create_table_option =
             CreateTableOption::ColumnDefinitions(CreateTableColumnDef {
@@ -320,7 +320,7 @@ mod test_create_table_statement_parser {
     }
 
     #[test]
-    fn test_parse_create_table_statement_with_table_options() {
+    fn create_table_with_table_options() {
         let table_options = vec![TableOption::WithoutRowId, TableOption::Strict];
 
         for option in table_options {

src/parser/create/create_trigger.rs

@@ -185,7 +185,7 @@ pub mod test_utils {
 }
 
 #[cfg(test)]
-mod test_create_trigger_statements {
+mod create_trigger_tests {
     use std::fmt::Display;
 
     use crate::{
@@ -203,7 +203,7 @@ mod test_create_trigger_statements {
     };
 
     #[test]
-    fn test_create_trigger_statement() {
+    fn create_trigger_test() {
         let expected = create_trigger_statement();
         run_sunny_day_test(
             "CREATE TRIGGER trigger_name DELETE ON table_name BEGIN SELECT * FROM table_name; END;",
@@ -212,7 +212,7 @@ mod test_create_trigger_statements {
     }
 
     #[test]
-    fn test_create_temporary_trigger_statement() {
+    fn create_temporary_trigger_test() {
         let temp_keywords = vec![Keyword::Temporary, Keyword::Temp];
         let mut expected = create_trigger_statement();
         expected.temporary = true;
@@ -226,7 +226,7 @@ mod test_create_trigger_statements {
     }
 
     #[test]
-    fn test_create_trigger_statement_with_if_not_exists() {
+    fn create_trigger_with_if_not_exists() {
         let mut expected = create_trigger_statement();
         expected.if_not_exists = true;
 
@@ -237,7 +237,7 @@ mod test_create_trigger_statements {
     }
 
     #[test]
-    fn test_create_trigger_statement_with_trigger_schema() {
+    fn create_trigger_with_trigger_schema() {
         let mut expected = create_trigger_statement();
         expected.trigger_name =
             Identifier::Compound(vec!["schema_name".to_string(), "trigger_name".to_string()]);
@@ -249,7 +249,7 @@ mod test_create_trigger_statements {
     }
 
     #[test]
-    fn test_create_trigger_statement_with_trigger_pre_conditions() {
+    fn create_trigger_with_trigger_pre_conditions() {
         let trigger_pre_conditions = vec![
             TriggerPreCondition::Before,
             TriggerPreCondition::After,
@@ -271,7 +271,7 @@ mod test_create_trigger_statements {
     }
 
     #[test]
-    fn test_create_trigger_statement_with_trigger_event_types() {
+    fn create_trigger_with_trigger_event_types() {
         let trigger_event_types = vec![
             TriggerEventType::Delete,
             TriggerEventType::Insert,
@@ -331,7 +331,7 @@ mod test_create_trigger_statements {
     }
 
     #[test]
-    fn test_create_trigger_statement_with_for_each_row() {
+    fn create_trigger_with_for_each_row() {
         let mut expected = create_trigger_statement();
         expected.for_each_row = true;
 
@@ -342,7 +342,7 @@ mod test_create_trigger_statements {
     }
 
     #[test]
-    fn test_create_trigger_statement_with_when_clause() {
+    fn create_trigger_with_when_clause() {
         let mut expected = create_trigger_statement();
         expected.when_clause = Some(binary_op_expression(
             BinaryOp::Equals,
@@ -357,7 +357,7 @@ mod test_create_trigger_statements {
     }
 
     #[test]
-    fn test_create_trigger_statement_with_multiple_statements() {
+    fn create_trigger_with_multiple_statements() {
         let mut expected = create_trigger_statement();
         expected.trigger_statements = vec![
             TriggerStatement::Update(update_statement2()),

src/parser/create/create_view.rs

@@ -59,13 +59,13 @@ pub mod test_utils {
 }
 
 #[cfg(test)]
-mod test_create_view_statement_parser {
+mod create_view_tests {
     use crate::{parser::test_utils::run_sunny_day_test, Identifier, Statement};
 
     use super::test_utils::create_view_statement;
 
     #[test]
-    fn test_parse_create_view_statement() {
+    fn create_view_test() {
         let expected_stmt = create_view_statement();
         run_sunny_day_test(
             "CREATE VIEW view_name AS SELECT * FROM table_name",
@@ -74,7 +74,7 @@ mod test_create_view_statement_parser {
     }
 
     #[test]
-    fn test_parse_create_temporary_view_statement() {
+    fn create_temporary_view_test() {
         let mut expected_stmt = create_view_statement();
         expected_stmt.temporary = true;
         run_sunny_day_test(
@@ -88,7 +88,7 @@ mod test_create_view_statement_parser {
     }
 
     #[test]
-    fn test_parse_create_view_statement_with_if_not_exists() {
+    fn create_view_with_if_not_exists() {
         let mut expected_stmt = create_view_statement();
         expected_stmt.if_not_exists = true;
         run_sunny_day_test(
@@ -98,7 +98,7 @@ mod test_create_view_statement_parser {
     }
 
     #[test]
-    fn test_parse_create_view_statement_with_schema_name() {
+    fn create_view_with_schema_name() {
         let mut expected_stmt = create_view_statement();
         expected_stmt.view_name =
             Identifier::Compound(vec!["schema_name".to_string(), "view_name".to_string()]);
@@ -109,7 +109,7 @@ mod test_create_view_statement_parser {
     }
 
     #[test]
-    fn test_parse_create_view_statement_with_columns() {
+    fn create_view_with_columns() {
         let mut expected_stmt = create_view_statement();
         expected_stmt.columns = vec![Identifier::from("column1"), Identifier::from("column2")];
         run_sunny_day_test(

src/parser/create/create_virtual_table.rs

@@ -68,7 +68,7 @@ pub mod test_utils {
 }
 
 #[cfg(test)]
-mod tests_create_virtual_table_parser {
+mod create_virtual_table_tests {
     use test_utils::create_virtual_table_statement;
 
     use crate::{
@@ -79,15 +79,15 @@ mod tests_create_virtual_table_parser {
     use super::*;
 
     #[test]
-    fn test_parse_create_virtual_table_statement_default() {
+    fn create_virtual_table_test() {
         run_sunny_day_test(
             "CREATE VIRTUAL TABLE test_table USING test_module",
             Statement::CreateVirtualTable(create_virtual_table_statement()),
         );
     }
 
     #[test]
-    fn test_parse_create_virtual_table_statement_if_not_exists() {
+    fn create_virtual_table_with_if_not_exists() {
         let mut stmt = create_virtual_table_statement();
         stmt.if_not_exists = true;
 
@@ -98,7 +98,7 @@ mod tests_create_virtual_table_parser {
     }
 
     #[test]
-    fn test_parse_create_virtual_table_statement_with_schema() {
+    fn create_virtual_table_with_schema() {
         let mut stmt = create_virtual_table_statement();
         stmt.table_name =
             Identifier::Compound(vec!["test_schema".to_string(), "test_table".to_string()]);
@@ -110,7 +110,7 @@ mod tests_create_virtual_table_parser {
     }
 
     #[test]
-    fn test_parse_create_virtual_table_statement_with_module_arguments() {
+    fn create_virtual_table_with_module_arguments() {
         let mut stmt = create_virtual_table_statement();
         stmt.module_arguments = vec![
             string_literal_expression("'arg1'"),