Use package:pedantic for analysis configuration.

davidmorgan · davidmorgan · commit ac696329090b · 2019-04-04T16:21:04.000+02:00
diff --git a/analysis_options.yaml b/analysis_options.yaml
diff --git a/benchmark/analysis_options.yaml b/benchmark/analysis_options.yaml
@@ -0,0 +1 @@
+include: package:pedantic/analysis_options.yaml
diff --git a/benchmark/pubspec.yaml b/benchmark/pubspec.yaml
@@ -16,5 +16,6 @@ dependencies:
 dev_dependencies:
   build_runner: ^1.0.0
   built_value_generator: ^6.3.2
+  pedantic: ^1.4.0
   quiver: '>=0.21.0 <3.0.0'
   test: ^1.0.0
diff --git a/built_value/analysis_options.yaml b/built_value/analysis_options.yaml
@@ -0,0 +1 @@
+include: package:pedantic/analysis_options.yaml
diff --git a/built_value/pubspec.yaml b/built_value/pubspec.yaml
@@ -17,4 +17,5 @@ dependencies:
   quiver: '>=0.21.0 <3.0.0'
 
 dev_dependencies:
+  pedantic: ^1.4.0
   test: ^1.0.0
diff --git a/built_value_generator/analysis_options.yaml b/built_value_generator/analysis_options.yaml
@@ -0,0 +1 @@
+include: package:pedantic/analysis_options.yaml
diff --git a/built_value_generator/lib/src/value_source_class.dart b/built_value_generator/lib/src/value_source_class.dart
@@ -665,7 +665,7 @@ abstract class ValueSourceClass
     if (!implementsToString) {
       result.writeln('@override');
       result.writeln('String toString() {');
-      if (fields.length == 0) {
+      if (fields.isEmpty) {
         result
             .writeln("return newBuiltValueToStringHelper('$name').toString();");
       } else {
@@ -921,7 +921,7 @@ abstract class ValueSourceClass
     result.writeln('@override');
     result.writeln('int get hashCode {');
 
-    if (comparedFields.length == 0) {
+    if (comparedFields.isEmpty) {
       result.writeln('return ${name.hashCode};');
     } else {
       result.writeln(r'return $jf(');
diff --git a/built_value_generator/pubspec.yaml b/built_value_generator/pubspec.yaml
@@ -24,4 +24,5 @@ dev_dependencies:
   build_test: ^0.10.3
   build_runner: ^1.0.0
   logging: ^0.11.0
+  pedantic: ^1.4.0
   test: ^1.0.0
diff --git a/built_value_test/analysis_options.yaml b/built_value_test/analysis_options.yaml
@@ -0,0 +1 @@
+include: package:pedantic/analysis_options.yaml
diff --git a/built_value_test/pubspec.yaml b/built_value_test/pubspec.yaml
@@ -20,3 +20,4 @@ dependencies:
 dev_dependencies:
   built_value_generator: ^6.3.2
   build_runner: ^1.0.0
+  pedantic: ^1.4.0
diff --git a/chat_example/analysis_options.yaml b/chat_example/analysis_options.yaml
@@ -0,0 +1 @@
+include: package:pedantic/analysis_options.yaml
diff --git a/chat_example/pubspec.yaml b/chat_example/pubspec.yaml
@@ -20,4 +20,5 @@ dependencies:
 dev_dependencies:
   build_runner: ^1.0.0
   built_value_generator: ^6.3.2
+  pedantic: ^1.4.0
   test: ^1.0.0
diff --git a/end_to_end_test/analysis_options.yaml b/end_to_end_test/analysis_options.yaml
@@ -0,0 +1 @@
+include: package:pedantic/analysis_options.yaml
diff --git a/end_to_end_test/pubspec.yaml b/end_to_end_test/pubspec.yaml
@@ -18,5 +18,6 @@ dev_dependencies:
   build_runner: ^1.0.0
   built_value_generator: ^6.3.2
   fixnum: ^0.10.0
+  pedantic: ^1.4.0
   quiver: '>=0.21.0 <3.0.0'
   test: ^1.0.0
diff --git a/example/analysis_options.yaml b/example/analysis_options.yaml
@@ -0,0 +1 @@
+include: package:pedantic/analysis_options.yaml
diff --git a/example/pubspec.yaml b/example/pubspec.yaml
@@ -16,5 +16,6 @@ dependencies:
 dev_dependencies:
   build_runner: ^1.0.0
   built_value_generator: ^6.3.2
+  pedantic: ^1.4.0
   quiver: '>=0.21.0 <3.0.0'
   test: ^1.0.0

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+include: package:pedantic/analysis_options.yaml`