Skip to content

Commit ac69632

Browse files
committed
Use package:pedantic for analysis configuration.
1 parent 0062329 commit ac69632

16 files changed

+16
-79
lines changed

analysis_options.yaml

-77
This file was deleted.

benchmark/analysis_options.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
include: package:pedantic/analysis_options.yaml

benchmark/pubspec.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -16,5 +16,6 @@ dependencies:
1616
dev_dependencies:
1717
build_runner: ^1.0.0
1818
built_value_generator: ^6.3.2
19+
pedantic: ^1.4.0
1920
quiver: '>=0.21.0 <3.0.0'
2021
test: ^1.0.0

built_value/analysis_options.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
include: package:pedantic/analysis_options.yaml

built_value/pubspec.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,5 @@ dependencies:
1717
quiver: '>=0.21.0 <3.0.0'
1818

1919
dev_dependencies:
20+
pedantic: ^1.4.0
2021
test: ^1.0.0
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
include: package:pedantic/analysis_options.yaml

built_value_generator/lib/src/value_source_class.dart

+2-2
Original file line numberDiff line numberDiff line change
@@ -665,7 +665,7 @@ abstract class ValueSourceClass
665665
if (!implementsToString) {
666666
result.writeln('@override');
667667
result.writeln('String toString() {');
668-
if (fields.length == 0) {
668+
if (fields.isEmpty) {
669669
result
670670
.writeln("return newBuiltValueToStringHelper('$name').toString();");
671671
} else {
@@ -921,7 +921,7 @@ abstract class ValueSourceClass
921921
result.writeln('@override');
922922
result.writeln('int get hashCode {');
923923

924-
if (comparedFields.length == 0) {
924+
if (comparedFields.isEmpty) {
925925
result.writeln('return ${name.hashCode};');
926926
} else {
927927
result.writeln(r'return $jf(');

built_value_generator/pubspec.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -24,4 +24,5 @@ dev_dependencies:
2424
build_test: ^0.10.3
2525
build_runner: ^1.0.0
2626
logging: ^0.11.0
27+
pedantic: ^1.4.0
2728
test: ^1.0.0
+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
include: package:pedantic/analysis_options.yaml

built_value_test/pubspec.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -20,3 +20,4 @@ dependencies:
2020
dev_dependencies:
2121
built_value_generator: ^6.3.2
2222
build_runner: ^1.0.0
23+
pedantic: ^1.4.0

chat_example/analysis_options.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
include: package:pedantic/analysis_options.yaml

chat_example/pubspec.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -20,4 +20,5 @@ dependencies:
2020
dev_dependencies:
2121
build_runner: ^1.0.0
2222
built_value_generator: ^6.3.2
23+
pedantic: ^1.4.0
2324
test: ^1.0.0

end_to_end_test/analysis_options.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
include: package:pedantic/analysis_options.yaml

end_to_end_test/pubspec.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -18,5 +18,6 @@ dev_dependencies:
1818
build_runner: ^1.0.0
1919
built_value_generator: ^6.3.2
2020
fixnum: ^0.10.0
21+
pedantic: ^1.4.0
2122
quiver: '>=0.21.0 <3.0.0'
2223
test: ^1.0.0

example/analysis_options.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
include: package:pedantic/analysis_options.yaml

example/pubspec.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -16,5 +16,6 @@ dependencies:
1616
dev_dependencies:
1717
build_runner: ^1.0.0
1818
built_value_generator: ^6.3.2
19+
pedantic: ^1.4.0
1920
quiver: '>=0.21.0 <3.0.0'
2021
test: ^1.0.0

0 commit comments

Comments
 (0)