Release 8.0.0-nullsafety.0. (google#946)

* Release 8.0.0-nullsafety.0 `built_value`, not ready for `built_value_generator` yet.
* Use null safe package test.
* Update and run tool/presubmit.
* Fix `built_value_test` goldens.
* Update `chat_example` pubspec and generated files.
* Update `example` pubspec and generated files.

Author: davidmorgan

CHANGELOG.md

@@ -1,6 +1,6 @@
 # Changelog
 
-# 8.0.0 (unmigrated)
+# 8.0.0-nullsafety.0
 
 - Migrate to NNBD.
 - Remove dependency on `package:quiver`.

benchmark/lib/node.g.dart

@@ -1,5 +1,5 @@
 name: benchmark
-version: 7.1.0
+version: 8.0.0-nullsafety.0
 publish_to: none
 description: >
   Benchmark, not for publishing.
@@ -14,13 +14,14 @@ dependencies:
 
 dev_dependencies:
   build_runner: ^1.0.0
-  built_value_generator: ^7.1.0
+  built_value_generator: # ^8.0.0-nullsafety.0
+    path: ../built_value_generator
   pedantic: ^1.4.0
   quiver: '>=0.21.0 <3.0.0'
   test: ^1.0.0
 
+# Dependency overrides are needed to use null safe `built_value` until it rolls
+# into `package:build_runner`.
 dependency_overrides:
-  built_value:
-    path: ../built_value
-  built_value_generator:
-    path: ../built_value_generator
+  built_collection: 5.0.0-nullsafety.0
+  built_value: 8.0.0-nullsafety.0

benchmark/lib/simple_value.g.dart

@@ -1,101 +1,18 @@
 name: built_value
-version: 7.1.0
+version: 8.0.0-nullsafety.0
 description: >
   Value types with builders, Dart classes as enums, and serialization.
   This library is the runtime dependency.
 homepage: https://github.com/google/built_value.dart
 
 environment:
-  sdk: '>=2.9.0-18.0 <2.10.0'
-
+  sdk: '>=2.12.0-0 <3.0.0'
 
 dependencies:
-  built_collection: ^5.0.0
-  collection: ^1.0.0
-  fixnum: ^1.0.0
+  built_collection: ^5.0.0-nullsafety
+  collection: ^1.15.0-nullsafety
+  fixnum: ^1.0.0-nullsafety
 
 dev_dependencies:
   pedantic: ^1.4.0
-  test: ^1.0.0
-
-dependency_overrides:
-  built_collection:
-    git:
-      url: git://github.com/google/built_collection.dart.git
-      ref: 88de195928b75fc5dd25507baed14cf45c267a62
-  async:
-    git:
-      url: git://github.com/dart-lang/async.git
-      ref: null_safety
-  boolean_selector:
-    git:
-      url: git://github.com/dart-lang/boolean_selector.git
-      ref: null_safety
-  charcode:
-    git:
-      url: git://github.com/dart-lang/charcode.git
-      ref: null_safety
-  collection:
-    git:
-      url: git://github.com/dart-lang/collection.git
-      ref: null_safety
-  fixnum:
-    git:
-      url: git://github.com/dart-lang/fixnum.git
-      ref: 9b38f49f6679654d66a363e69e48173cca07e882
-  matcher:
-    git:
-      url: git://github.com/dart-lang/matcher.git
-      ref: null_safety
-  meta:
-    git:
-      url: git://github.com/dart-lang/sdk.git
-      ref: null_safety-pkgs
-      path: pkg/meta
-  path:
-    git:
-      url: git://github.com/dart-lang/path.git
-      ref: null_safety
-  pedantic:
-    git:
-      url: git://github.com/dart-lang/pedantic.git
-      ref: null_safety
-  pool:
-    git:
-      url: git://github.com/dart-lang/pool.git
-      ref: null_safety
-  source_span:
-    git:
-      url: git://github.com/dart-lang/source_span.git
-      ref: null_safety
-  stack_trace:
-    git:
-      url: git://github.com/dart-lang/stack_trace.git
-      ref: null_safety
-  stream_channel:
-    git:
-      url: git://github.com/dart-lang/stream_channel.git
-      ref: null_safety
-  string_scanner:
-    git:
-      url: git://github.com/dart-lang/string_scanner.git
-      ref: null_safety
-  term_glyph:
-    git:
-      url: git://github.com/dart-lang/term_glyph.git
-      ref: null_safety
-  test_api:
-    git:
-      url: git://github.com/dart-lang/test.git
-      ref: null_safety
-      path: pkgs/test_api
-  test_core:
-    git:
-      url: git://github.com/dart-lang/test.git
-      ref: null_safety
-      path: pkgs/test_core
-  test:
-    git:
-      url: git://github.com/dart-lang/test.git
-      ref: null_safety
-      path: pkgs/test
+  test: ^1.16.0-nullsafety

benchmark/pubspec.yaml

@@ -58,6 +58,6 @@ class TestSerializer implements PrimitiveSerializer<Object?> {
   @override
   Object serialize(Serializers serializers, Object? object,
       {FullType specifiedType = FullType.unspecified}) {
-    return null!;
+    return '';
   }
 }

built_value/pubspec.yaml

@@ -1,5 +1,5 @@
 name: built_value_analyzer_plugin
-version: 7.1.0
+version: 8.0.0-nullsafety.0
 description: >
   Experimental analyzer plugin for the built_value code generator.
 homepage: https://github.com/google/built_value.dart
@@ -11,15 +11,9 @@ dependencies:
   analyzer: '>=0.39.0 <0.40.0'
   analyzer_plugin: '>=0.1.0 <0.3.0'
   built_value: '>=7.0.0 <7.1.0'
-  built_value_generator: ^7.1.0
+  built_value_generator: ^8.0.0-nullsafety.0
 
 dev_dependencies:
   build_test: ^0.10.3
   pedantic: ^1.4.0
   test: ^1.0.0
-
-dependency_overrides:
-  built_value:
-    path: ../built_value
-  built_value_generator:
-    path: ../built_value_generator

built_value/test/serializers_test.dart

@@ -1,6 +1,7 @@
 // Copyright (c) 2018, Google Inc. Please see the AUTHORS file for details.
 // All rights reserved. Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
+// @dart=2.11
 
 import 'package:build/build.dart';
 

built_value_analyzer_plugin/pubspec.yaml

@@ -1,6 +1,7 @@
 // Copyright (c) 2015, Google Inc. Please see the AUTHORS file for details.
 // All rights reserved. Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
+// @dart=2.11
 
 import 'package:analyzer/dart/element/element.dart';
 import 'package:build/build.dart';
@@ -18,12 +19,29 @@ class BuiltValueGenerator extends Generator {
 
   @override
   Future<String> generate(LibraryReader library, BuildStep buildStep) async {
-    var result = StringBuffer();
+    // Workaround for https://github.com/google/built_value.dart/issues/941.
+    LibraryElement libraryElement;
+    var attempts = 0;
+    while (true) {
+      try {
+        libraryElement = await buildStep.resolver.libraryFor(
+            await buildStep.resolver.assetIdForElement(library.element));
+        libraryElement.session.getParsedLibraryByElement(libraryElement);
+        break;
+      } catch (_) {
+        ++attempts;
+        if (attempts == 10) {
+          log.severe('Analysis session did not stabilize after ten tries!');
+          return null;
+        }
+      }
+    }
 
+    var result = StringBuffer();
     try {
-      final enumCode = EnumSourceLibrary(library.element).generateCode();
+      final enumCode = EnumSourceLibrary(libraryElement).generateCode();
       if (enumCode != null) result.writeln(enumCode);
-      final serializerSourceLibrary = SerializerSourceLibrary(library.element);
+      final serializerSourceLibrary = SerializerSourceLibrary(libraryElement);
       if (serializerSourceLibrary.needsBuiltJson ||
           serializerSourceLibrary.hasSerializers) {
         result.writeln(serializerSourceLibrary.generateCode());
@@ -32,21 +50,20 @@ class BuiltValueGenerator extends Generator {
       result.writeln(_error(e.message));
       log.severe(
           'Error in BuiltValueGenerator for '
-          '${library.element.source.fullName}.',
+          '${libraryElement.source.fullName}.',
           e,
           st);
     } catch (e, st) {
       result.writeln(_error(e.toString()));
       log.severe(
           'Unknown error in BuiltValueGenerator for '
-          '${library.element.source.fullName}.',
+          '${libraryElement.source.fullName}.',
           e,
           st);
     }
 
-    for (var element in library.allElements) {
-      if (element is ClassElement &&
-          ValueSourceClass.needsBuiltValue(element)) {
+    for (var element in libraryElement.units.expand((unit) => unit.types)) {
+      if (ValueSourceClass.needsBuiltValue(element)) {
         try {
           result.writeln(ValueSourceClass(element).generateCode() ?? '');
         } catch (e, st) {

built_value_generator/lib/builder.dart

@@ -1,6 +1,7 @@
 // Copyright (c) 2017, Google Inc. Please see the AUTHORS file for details.
 // All rights reserved. Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
+// @dart=2.11
 
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/dart/element/type.dart';

built_value_generator/lib/built_value_generator.dart

@@ -1,6 +1,7 @@
 // Copyright (c) 2016, Google Inc. Please see the AUTHORS file for details.
 // All rights reserved. Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
+// @dart=2.11
 
 library built_value_generator.enum_source_class;