Skip to content

Commit 3e35c7d

Browse files
rbtcollinsdavidB
authored andcommitted
Replace let _ with let _enter
See discussion here: rust-lang/rust-clippy#8246 tl;dr: `let _` drops immediately, so for anything that has Guard like behavior, it will not work as expected. `let _enter` will ensure that the guard is dropped at the end of the scope.
1 parent aa51cb9 commit 3e35c7d

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

axum-tracing-opentelemetry/src/middleware/trace_extractor.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ where
135135
tracing::Span::none()
136136
};
137137
let future = {
138-
let _ = span.enter();
138+
let _enter = span.enter();
139139
self.inner.call(req)
140140
};
141141
ResponseFuture {

tonic-tracing-opentelemetry/src/middleware/client.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ where
6464
let span = otel_http::grpc_client::make_span_from_request(&req);
6565
otel_http::inject_context(&find_context_from_tracing(&span), req.headers_mut());
6666
let future = {
67-
let _ = span.enter();
67+
let _enter = span.enter();
6868
self.inner.call(req)
6969
};
7070
ResponseFuture {

tonic-tracing-opentelemetry/src/middleware/server.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ where
8686
tracing::Span::none()
8787
};
8888
let future = {
89-
let _ = span.enter();
89+
let _enter = span.enter();
9090
self.inner.call(req)
9191
};
9292
ResponseFuture {

0 commit comments

Comments
 (0)