where exactly is rofi_view_keyboard_navigation?

[ana-rchy]

was trying to do add a keybind to rofi for an issue im working on, but came across this in a comment in view.c, but searching for it brings no results. and i suspect thats why my keybind isnt recognised in the first place after i had compiled my fork, but i have no clue where this is so yeah

[DaveDavenport]

I think that is a stale comment. you can ignore it.

[ana-rchy]

actually, i wonder: could you instead set state->retv to be a bitwise xor of two preexisting MenuReturn values, and then check for that in file_browser_mode_result with smth like (mretv & (MENU_X ^ MENU_Y)) == (MENU_X ^ MENU_Y)? you could of course also just use a bitwise shift

i wanna try writing this out to see if it works so give me a min

[DaveDavenport]

I am not sure what you want to do, but I am not going to change this at this point in time as it would break plugins and bindings.

[ana-rchy]

just to clear up a few things: the reason for this: state->retv = MENU_CUSTOM_INPUT | MENU_CUSTOM_ACTION; on ACCEPT_CUSTOM_ALT is specifically to distinguish it from ACCEPT_CUSTOM by means of being able to bitwise-and with both MENU_CUSTOM_ACTION and MENU_CUSTOM_INPUT, which results in special_command being true and letting the whole parent directory keybind happen instead of just a regular file selection?

also, would i be right in saying **input is representing the string name of file? it seems to be implied by the line char *p = rofi_expand_path(*input);

[DaveDavenport]

First seems correct, it works this way for maintaining backwards compatibility of the mode interface. At some point this will be redone, but it will mean breakage of bindings and plugins.

*input is a pointer that possibly points to string the user entered in the entry (input) box.

[ana-rchy]

to clarify what i was trying to do: i was gonna attempt to make a keybind for going to the previously visited directory, but i realized id need to add a variable to hold the path of the previous directory into RofiViewState and then pass and return that value to/from file_browser_mode_result

i wanna try to do this myself, as im trying to do this in other to actually gain experience in open-source contribution that isnt just fixing up typos