Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix retry on socket error #432

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

luccailliau
Copy link

Hello,

Please correct if I am wrong. Reading about the retry mechanisms in the RequestExecution class, I found something very strange and I think it is an error:

  1. This portion of code, in the best case and in non-strict mode only rethrow in a non-standard way with an err value as a number instead of an error object.

  2. In strict mode, as specified at the top of the file, calling this method should raise Error: Cannot create property 'coordinator' on number 'err' at this line.

Potentially generating an erroneous error in business code without providing the desired logic.

Thank you very much for your response.

Have a good day,
Luc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant