Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Please correct if I am wrong. Reading about the retry mechanisms in the
RequestExecution
class, I found something very strange and I think it is an error:This portion of code, in the best case and in non-strict mode only rethrow in a non-standard way with an
err
value as anumber
instead of an error object.In strict mode, as specified at the top of the file, calling this method should raise
Error: Cannot create property 'coordinator' on number 'err'
at this line.Potentially generating an erroneous error in business code without providing the desired logic.
Thank you very much for your response.
Have a good day,
Luc