-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set default data_security_mode to "SINGLE_USER" in bundle templates #2372
Conversation
69f3491
to
ce7a67e
Compare
…" in default python template
… (keeping newly introduced data_security_mode field)
ce7a67e
to
ad2cc89
Compare
From description:
This seems to duplicate the title. Could you instead add some background, why is this done, what is going to be the behaviour change for users of the templates, what are the risks.
Test descriptions belong in 'Tests' section. It should be specific. if you're relying on existing tests you can omit it or add 'Existing tests'. From title:
nit: possible shorter title: 'Set data_security_mode to SINGLE_USER in default-python template' |
@anton-107 Could you apply the same to the It can be a separate PR. FYI @kanterov |
…in experimental-jobs-as-code template
data_security_mode
set to "SINGLE_USER" in default python template
Changes
data_security_mode
of a cluster to SINGLE_USERdata_security_mode
of a cluster to SINGLE_USERWhy
Explicitly adding this field saves experienced users from confusion onto what security mode is applied to the cluster
Tests
Changed existing unit and integration tests to pass with this change