Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default data_security_mode to "SINGLE_USER" in bundle templates #2372

Merged
merged 3 commits into from
Feb 26, 2025

Conversation

anton-107
Copy link
Contributor

@anton-107 anton-107 commented Feb 24, 2025

Changes

  1. Change the default-python bundle template to set data_security_mode of a cluster to SINGLE_USER
  2. Change the experimental-jobs-as-code bundle template to set data_security_mode of a cluster to SINGLE_USER

Why

Explicitly adding this field saves experienced users from confusion onto what security mode is applied to the cluster

Tests

Changed existing unit and integration tests to pass with this change

@anton-107 anton-107 force-pushed the default-security-mode branch from 69f3491 to ce7a67e Compare February 24, 2025 16:26
@anton-107 anton-107 marked this pull request as ready for review February 25, 2025 10:42
@anton-107 anton-107 requested a review from denik February 25, 2025 10:42
@denik
Copy link
Contributor

denik commented Feb 26, 2025

From description:

Change the default Python project template to set data_security_mode of a cluster to SINGLE_USER

This seems to duplicate the title. Could you instead add some background, why is this done, what is going to be the behaviour change for users of the templates, what are the risks.

Change existing unit and integration tests to work with this change

Test descriptions belong in 'Tests' section. It should be specific. if you're relying on existing tests you can omit it or add 'Existing tests'.

From title:

Add default cluster property data_security_mode set to "SINGLE_USER" in default python template

nit: possible shorter title: 'Set data_security_mode to SINGLE_USER in default-python template'

@pietern
Copy link
Contributor

pietern commented Feb 26, 2025

@anton-107 Could you apply the same to the experimental-jobs-as-code template? It applies the same pattern as this template so updating it should be straightforward.

It can be a separate PR.

FYI @kanterov

@anton-107 anton-107 changed the title Add default cluster property data_security_mode set to "SINGLE_USER" in default python template Set default data_security_mode to "SINGLE_USER" in bundle templates Feb 26, 2025
@anton-107 anton-107 merged commit 428e730 into main Feb 26, 2025
8 of 9 checks passed
@anton-107 anton-107 deleted the default-security-mode branch February 26, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants