remove code because bug in FE has been fixed

ginberg · ginberg · commit 04b99787bff6 · 2024-10-11T14:52:42.000+02:00
diff --git a/R/executeDiagnostics.R b/R/executeDiagnostics.R
@@ -358,11 +358,6 @@ executeDiagnostics <- function(cohortDefinitionSet,
       )
     }
 
-    # forcefully set ConditionEraGroupStart and drugEraGroupStart to NULL
-    # because of known bug in FeatureExtraction. https://github.com/OHDSI/FeatureExtraction/issues/144
-    temporalCovariateSettings[[1]]$ConditionEraGroupStart <- NULL
-    temporalCovariateSettings[[1]]$DrugEraGroupStart <- NULL
-
     checkmate::assert_integerish(
       x = temporalCovariateSettings[[1]]$temporalStartDays,
       any.missing = FALSE,

Original file line number	Diff line number	Diff line change
`@@ -358,11 +358,6 @@ executeDiagnostics <- function(cohortDefinitionSet,`
`358`	`358`	`)`
`359`	`359`	`}`
`360`	`360`
`361`		`- # forcefully set ConditionEraGroupStart and drugEraGroupStart to NULL`
`362`		`- # because of known bug in FeatureExtraction. https://github.com/OHDSI/FeatureExtraction/issues/144`
`363`		`- temporalCovariateSettings[[1]]$ConditionEraGroupStart <- NULL`
`364`		`- temporalCovariateSettings[[1]]$DrugEraGroupStart <- NULL`
`365`		`-`
`366`	`361`	`checkmate::assert_integerish(`
`367`	`362`	`x = temporalCovariateSettings[[1]]$temporalStartDays,`
`368`	`363`	`any.missing = FALSE,`